From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="p9e6tLHG" Received: from www530.your-server.de (www530.your-server.de [188.40.30.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07CFB2307D; Wed, 6 Dec 2023 01:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=geanix.com; s=default2211; h=To:References:Message-Id:Content-Transfer-Encoding:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Content-Type:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID; bh=N1jod1FzkmkyxyVQNDl6jeYBZoBJ7X9ZIXt3HjQG3ww=; b=p9e6tLHGOQyi4rJ1HvNgO197jfZkk7UuwH1lNpexEYEl+LZ2UI1nOHzifcPYe7aPeTwg2KqbzVd kYGkvJEb4nI++qmSp0rsNXZAGHUBI6+zdWs3BG+Hy7THmpQ/nngTKVt0KpImDJVLyLCw2jwF3v9qp IDH9/K9vWQ7GcUndNYnlOjBGb8x/i/0iDd3EDZWTKSOVcXND3YwJnBockhIDigXPVo924gLEmgLp5 ypJGSbG2bWBT6Q+uZdKwKy567yEb2BK0XbJD/uxSR5oxLg9N6ymy58jbongX4i/4g/F3CcNvoBlD8 RiFbWiUYZTJ0Kc5g3TUzYZPZs3tl7Opg6lPQ==; Received: from sslproxy02.your-server.de ([78.47.166.47]) by www530.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAnmB-0000yr-L2; Wed, 06 Dec 2023 10:01:03 +0100 Received: from [185.17.218.86] (helo=smtpclient.apple) by sslproxy02.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1rAnmB-000LsT-0z; Wed, 06 Dec 2023 10:01:03 +0100 Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define From: Sean Nyekjaer In-Reply-To: Date: Wed, 6 Dec 2023 10:00:52 +0100 Cc: Woojung.Huh@microchip.com, UNGLinuxDriver@microchip.com, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20231206072442.1628505-1-sean@geanix.com> To: Arun.Ramadoss@microchip.com X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Authenticated-Sender: sean@geanix.com X-Virus-Scanned: Clear (ClamAV 0.103.10/27114/Tue Dec 5 09:39:00 2023) Hi Arun, > On 6 Dec 2023, at 09.58, = wrote: >=20 > Hi Sean, >=20 >> -----Original Message----- >> From: Sean Nyekjaer >> Sent: Wednesday, December 6, 2023 12:55 PM >> To: Woojung Huh - C21699 ; >> UNGLinuxDriver ; Andrew Lunn >> ; Florian Fainelli ; Vladimir = Oltean >> ; David S. Miller ; Eric >> Dumazet ; Jakub Kicinski ; >> Paolo Abeni ; Arun Ramadoss - I17769 >> >> Cc: Sean Nyekjaer ; netdev@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without >> _VALUE define >>=20 >> [Some people who received this message don't often get email from >> sean@geanix.com. Learn why this is important at >> https://aka.ms/LearnAboutSenderIdentification ] >>=20 >> EXTERNAL EMAIL: Do not click links or open attachments unless you = know the >> content is safe >>=20 >> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to >> DSA_TAG_PROTO_LAN937X to improve readability. >>=20 >> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add = dsa_tag_protocol") >> Signed-off-by: Sean Nyekjaer >=20 > Not sure, whether it is a bug fix or not. Since it only improves = readability. > I believe it should point to net-next.=20 >=20 Agree :) Feel free to remove the Fixes tag while applying. /Sean=