From: Florian Fainelli <f.fainelli@gmail.com>
To: Petri Gynther <pgynther@google.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jaedon.shin@gmail.com, edumazet@google.com
Subject: Re: [PATCH net 1/2] net: bcmgenet: fix dev->stats.tx_bytes accounting
Date: Wed, 23 Mar 2016 15:02:33 -0700 [thread overview]
Message-ID: <B161205E-3917-42F9-9831-BA05F94FCCB9@gmail.com> (raw)
In-Reply-To: <1458763289-95167-1-git-send-email-pgynther@google.com>
On March 23, 2016 1:01:28 PM PDT, Petri Gynther <pgynther@google.com> wrote:
>1. Add bytes_compl local variable to collect transmitted bytes
> - dev->stats updates can then be moved outside the while-loop
> - bytes_compl is also needed for future BQL support
>2. When bcmgenet device uses Tx checksum offload, each transmitted
> skb has an extra 64-byte header prepended to it. This needs to
> be deducted when counting transmitted bytes.
>3. skb->len covers the entire length of skb, whether it is linear or
> fragmented. Thus, when we clean the fragments, do not increase
> transmitted bytes.
>
>Signed-off-by: Petri Gynther <pgynther@google.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
--
Florian
next prev parent reply other threads:[~2016-03-23 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 20:01 [PATCH net 1/2] net: bcmgenet: fix dev->stats.tx_bytes accounting Petri Gynther
2016-03-23 20:01 ` [PATCH net 2/2] net: bcmgenet: fix skb_len in bcmgenet_xmit_single() Petri Gynther
2016-03-23 21:24 ` Eric Dumazet
2016-03-23 21:23 ` [PATCH net 1/2] net: bcmgenet: fix dev->stats.tx_bytes accounting Eric Dumazet
2016-03-23 21:47 ` Florian Fainelli
2016-03-23 22:02 ` Florian Fainelli [this message]
2016-03-23 22:09 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B161205E-3917-42F9-9831-BA05F94FCCB9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox