From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lawrence Brakmo Subject: Re: [PATCH v2 bpf-next 06/11] bpf: Add sock_ops RTO callback Date: Sun, 31 Dec 2017 11:20:56 +0000 Message-ID: References: <20171222012101.3899534-1-brakmo@fb.com> <20171222012101.3899534-7-brakmo@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev , Kernel Team , "Blake Matheny" , Alexei Starovoitov , Daniel Borkmann , Eric Dumazet , Neal Cardwell To: Yuchung Cheng Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:40856 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751026AbdLaLVf (ORCPT ); Sun, 31 Dec 2017 06:21:35 -0500 In-Reply-To: Content-Language: en-US Content-ID: <027C4A719D6C434A9BDD4B378F75BF4F@namprd15.prod.outlook.com> Sender: netdev-owner@vger.kernel.org List-ID: DQpPbiAxMi8yOC8xNywgOTo1OCBBTSwgIll1Y2h1bmcgQ2hlbmciIDx5Y2hlbmdAZ29vZ2xlLmNv bT4gd3JvdGU6DQoNCiAgICBPbiBUaHUsIERlYyAyMSwgMjAxNyBhdCA1OjIwIFBNLCBMYXdyZW5j ZSBCcmFrbW8gPGJyYWttb0BmYi5jb20+IHdyb3RlOg0KICAgID4NCiAgICA+IEFkZHMgYW4gb3B0 aW9uYWwgY2FsbCB0byBzb2NrX29wcyBCUEYgcHJvZ3JhbSBiYXNlZCBvbiB3aGV0aGVyIHRoZQ0K ICAgID4gQlBGX1NPQ0tfT1BTX1JUT19DQl9GTEFHIGlzIHNldCBpbiBicGZfc29ja19vcHNfZmxh Z3MuDQogICAgPiBUaGUgQlBGIHByb2dyYW0gaXMgcGFzc2VkIDIgYXJndW1lbnRzOiBpY3NrX3Jl dHJhbnNtaXRzIGFuZCB3aGV0aGVyIHRoZQ0KICAgID4gUlRPIGhhcyBleHBpcmVkLg0KICAgID4N CiAgICA+IFNpZ25lZC1vZmYtYnk6IExhd3JlbmNlIEJyYWttbyA8YnJha21vQGZiLmNvbT4NCiAg ICA+IC0tLQ0KICAgID4gIGluY2x1ZGUvdWFwaS9saW51eC9icGYuaCB8IDUgKysrKysNCiAgICA+ ICBpbmNsdWRlL3VhcGkvbGludXgvdGNwLmggfCAzICsrKw0KICAgID4gIG5ldC9pcHY0L3RjcF90 aW1lci5jICAgICB8IDkgKysrKysrKysrDQogICAgPiAgMyBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNl cnRpb25zKCspDQogICAgPg0KICAgID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvdWFwaS9saW51eC9i cGYuaCBiL2luY2x1ZGUvdWFwaS9saW51eC9icGYuaA0KICAgID4gaW5kZXggNjJiMmM4OS4uM2Nm OTAxNCAxMDA2NDQNCiAgICA+IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC9icGYuaA0KICAgID4g KysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L2JwZi5oDQogICAgPiBAQCAtOTk1LDYgKzk5NSwxMSBA QCBlbnVtIHsNCiAgICA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KiBhIGNvbmdlc3Rpb24gdGhyZXNob2xkLiBSVFRzIGFib3ZlDQogICAgPiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICogdGhpcyBpbmRpY2F0ZSBjb25nZXN0aW9uDQog ICAgPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICovDQogICAgPiAr ICAgICAgIEJQRl9TT0NLX09QU19SVE9fQ0IsICAgICAgICAgICAgLyogQ2FsbGVkIHdoZW4gYW4g UlRPIGhhcyB0cmlnZ2VyZWQuDQogICAgPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICogQXJnMTogdmFsdWUgb2YgaWNza19yZXRyYW5zbWl0cw0KICAgID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIEFyZzI6IHZhbHVlIG9mIGljc2tf cnRvDQogICAgPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICogQXJn Mzogd2hldGhlciBSVE8gaGFzIGV4cGlyZWQNCiAgICA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKi8NCiAgICA+ICB9Ow0KICAgID4NCiAgICA+ICAjZGVmaW5lIFRD UF9CUEZfSVcgICAgICAgICAgICAgMTAwMSAgICAvKiBTZXQgVENQIGluaXRpYWwgY29uZ2VzdGlv biB3aW5kb3cgKi8NCiAgICA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvdGNwLmgg Yi9pbmNsdWRlL3VhcGkvbGludXgvdGNwLmgNCiAgICA+IGluZGV4IGI0YTRmNjQuLjA4OWMxOWUg MTAwNjQ0DQogICAgPiAtLS0gYS9pbmNsdWRlL3VhcGkvbGludXgvdGNwLmgNCiAgICA+ICsrKyBi L2luY2x1ZGUvdWFwaS9saW51eC90Y3AuaA0KICAgID4gQEAgLTI1OSw2ICsyNTksOSBAQCBzdHJ1 Y3QgdGNwX21kNXNpZyB7DQogICAgPiAgICAgICAgIF9fdTggICAgdGNwbV9rZXlbVENQX01ENVNJ R19NQVhLRVlMRU5dOyAgICAgICAgIC8qIGtleSAoYmluYXJ5KSAqLw0KICAgID4gIH07DQogICAg Pg0KICAgID4gKy8qIERlZmluaXRpb25zIGZvciBicGZfc29ja19vcHNfZmxhZ3MgKi8NCiAgICA+ ICsjZGVmaW5lIEJQRl9TT0NLX09QU19SVE9fQ0JfRkxBRyAgICAgICAoMTw8MCkNCiAgICA+ICsN CiAgICA+ICAvKiBJTkVUX0RJQUdfTUQ1U0lHICovDQogICAgPiAgc3RydWN0IHRjcF9kaWFnX21k NXNpZyB7DQogICAgPiAgICAgICAgIF9fdTggICAgdGNwbV9mYW1pbHk7DQogICAgPiBkaWZmIC0t Z2l0IGEvbmV0L2lwdjQvdGNwX3RpbWVyLmMgYi9uZXQvaXB2NC90Y3BfdGltZXIuYw0KICAgID4g aW5kZXggNmRiMzEyNC4uZjljNTdlMiAxMDA2NDQNCiAgICA+IC0tLSBhL25ldC9pcHY0L3RjcF90 aW1lci5jDQogICAgPiArKysgYi9uZXQvaXB2NC90Y3BfdGltZXIuYw0KICAgID4gQEAgLTIxNSw5 ICsyMTUsMTggQEAgc3RhdGljIGludCB0Y3Bfd3JpdGVfdGltZW91dChzdHJ1Y3Qgc29jayAqc2sp DQogICAgPiAgICAgICAgIHRjcF9mYXN0b3Blbl9hY3RpdmVfZGV0ZWN0X2JsYWNraG9sZShzaywg ZXhwaXJlZCk7DQogICAgY2FuJ3Qgd2UganVzdCBjYWxsIGl0IGhlcmUgb25jZSB3LyAnZXhwaXJl ZCcgYXMgYSBwYXJhbWV0ZXIsIGluc3RlYWQNCiAgICBvZiBkdXBsaWNhdGluZyB0aGUgY29kZT8N Cg0KR29vZCBwb2ludCwgSSB3aWxsIGZpeCBpdC4gVGhhbmtzIQ0KICAgIA0KICAgID4gICAgICAg ICBpZiAoZXhwaXJlZCkgew0KICAgID4gICAgICAgICAgICAgICAgIC8qIEhhcyBpdCBnb25lIGp1 c3QgdG9vIGZhcj8gKi8NCiAgICA+ICsgICAgICAgICAgICAgICBpZiAoQlBGX1NPQ0tfT1BTX1RF U1RfRkxBRyh0cCwgQlBGX1NPQ0tfT1BTX1JUT19DQl9GTEFHKSkNCiAgICA+ICsgICAgICAgICAg ICAgICAgICAgICAgIHRjcF9jYWxsX2JwZl8zYXJnKHNrLCBCUEZfU09DS19PUFNfUlRPX0NCLA0K ICAgID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWNzay0+aWNz a19yZXRyYW5zbWl0cywNCiAgICA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGljc2stPmljc2tfcnRvLCAxKTsNCiAgICA+ICAgICAgICAgICAgICAgICB0Y3Bfd3Jp dGVfZXJyKHNrKTsNCiAgICA+ICAgICAgICAgICAgICAgICByZXR1cm4gMTsNCiAgICA+ICAgICAg ICAgfQ0KICAgID4gKw0KICAgID4gKyAgICAgICBpZiAoQlBGX1NPQ0tfT1BTX1RFU1RfRkxBRyh0 cCwgQlBGX1NPQ0tfT1BTX1JUT19DQl9GTEFHKSkNCiAgICA+ICsgICAgICAgICAgICAgICB0Y3Bf Y2FsbF9icGZfM2FyZyhzaywgQlBGX1NPQ0tfT1BTX1JUT19DQiwNCiAgICA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpY3NrLT5pY3NrX3JldHJhbnNtaXRzLA0KICAgID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGljc2stPmljc2tfcnRvLCAwKTsNCiAgICA+ ICAgICAgICAgcmV0dXJuIDA7DQogICAgPiAgfQ0KICAgID4NCiAgICA+IC0tDQogICAgPiAyLjku NQ0KICAgID4NCiAgICANCg0K