From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13172C433F5 for ; Wed, 6 Oct 2021 10:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFDBC61139 for ; Wed, 6 Oct 2021 10:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238066AbhJFKKM (ORCPT ); Wed, 6 Oct 2021 06:10:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33812 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237836AbhJFKKL (ORCPT ); Wed, 6 Oct 2021 06:10:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633514899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RD0kZmMRwV1oR0tBc71TpFfkf9QWoURBsG7TuBGdr7E=; b=OznYvoF3jSTNpdkt0RFqK6AAdYfknEBYcVaKoLuLdMTVEmJrjyodB8kxf7jNxrWRCd0Zwz +nvi+MLeGubA5hUtkQ8QtTbggxHUnM7hUZ+pObGufBt+5X57I0kcZS5sjsS7culQJXHc+w Vc0R62SlllxFSpzDDCt7saD9X5sMVAE= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-WG14eHjlOIqSI6g3uIAmrw-1; Wed, 06 Oct 2021 06:08:18 -0400 X-MC-Unique: WG14eHjlOIqSI6g3uIAmrw-1 Received: by mail-ed1-f71.google.com with SMTP id t28-20020a508d5c000000b003dad7fc5caeso2145183edt.11 for ; Wed, 06 Oct 2021 03:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RD0kZmMRwV1oR0tBc71TpFfkf9QWoURBsG7TuBGdr7E=; b=KELVhoa3I4sOMMVLR9udheWkIo7Xj10J4y9g8aZlDoSlthQ0Mj3tXCX6D4NnZVBsCz PN3WEaxkkzw5q+UQnoyIOupv78u8DoKq7rzCIzf9wv/e+OPy7kDhiAmL3aE7A/lh0CEY v8gTuTn9h7hZl4GaMZ3Skr2IW+NX6OW8VBE2wnB7aXs0ER4n5j0xuHaIdw0FchilelWu LHfX6w6JbsQnpdxh7cBvX56FA8ywYHPJVa5ZXYIOFDtuIGLvrr7LPEhMPsm7Eri7l5sy //DEt7zKSeXXI9EsUXyMOCD6lHE9NAihuaNXKegZy+m2t8gOB9mk8yFZAXM14UyHvtHD sXsw== X-Gm-Message-State: AOAM533R0JzImdZF+6/4zO6cyFBWV5OwBZnsHWrDcbjpTyIRv4wyK59K sFi15SOX2SNxhxkHFuff1FsXFSwF4z3Gvu8an+ejlgHfiB1H0B1lcLw7lCf20aOG53SdBYCnuEH HhQH44s7HCGnLOo2O X-Received: by 2002:a17:906:2cd6:: with SMTP id r22mr30354631ejr.398.1633514897445; Wed, 06 Oct 2021 03:08:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmoVgM2oKuMsMS3OhDrUiPb55LUAYV5+t2qx3p9ImNfbp4THX7Kd/rXZod2dhsnudaO4oZVA== X-Received: by 2002:a17:906:2cd6:: with SMTP id r22mr30354603ejr.398.1633514897279; Wed, 06 Oct 2021 03:08:17 -0700 (PDT) Received: from [10.39.193.81] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id z8sm8810012ejd.94.2021.10.06.03.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Oct 2021 03:08:16 -0700 (PDT) From: Eelco Chaudron To: Lorenzo Bianconi Cc: Jakub Kicinski , Lorenzo Bianconi , Toke =?utf-8?b?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Alexei Starovoitov , Lorenz Bauer , bpf , Networking , "David S . Miller" , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, John Fastabend , David Ahern , Jesper Dangaard Brouer , Jason Wang , Alexander Duyck , Saeed Mahameed , Maciej Fijalkowski , "Karlsson, Magnus" , tirthendu.sarkar@intel.com Subject: Re: [PATCH v14 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Date: Wed, 06 Oct 2021 12:08:16 +0200 X-Mailer: MailMate (1.14r5820) Message-ID: In-Reply-To: References: <20210916095539.4696ae27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87v92jinv7.fsf@toke.dk> <20210929122229.1d0c4960@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <87mtnvi0bc.fsf@toke.dk> <20211001113528.79f35460@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 6 Oct 2021, at 11:32, Lorenzo Bianconi wrote: >> On Fri, 1 Oct 2021 11:03:58 +0200 Lorenzo Bianconi wrote: >>> Can you please check if the code above is aligned to current requirem= ents or if >>> it is missing something? >>> If this code it is fine, I guess we have two option here: >>> - integrate the commits above in xdp multi-buff series (posting v15) = and work on >>> the verfier code in parallel (if xdp_mb_pointer helper is not requi= red from day0) >>> - integrate verfier changes in xdp multi-buff series, drop bpf_xdp_lo= ad_bytes >>> helper (probably we will still need bpf_xdp_store_bytes) and introd= uce >>> bpf_xdp_pointer as new ebpf helper. >> >> It wasn't clear to me that we wanted bpf_xdp_load_bytes() to exist. >> But FWIW no preference here. >> > > ack, same here. Any other opinion about it? I was under the impression getting a pointer might be enough. But playing= with the bpf ring buffers for a bit, it still might be handy to extract = some data to be sent to userspace. So I would not mind keeping it.