From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs Date: Fri, 15 Dec 2017 12:08:21 -0800 Message-ID: References: <1513302496-22888-1-git-send-email-f.fainelli@gmail.com> <20171215091044.GE929@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cphealy@gmail.com To: Andrew Lunn Return-path: Received: from mail-ot0-f196.google.com ([74.125.82.196]:40996 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755675AbdLOUI1 (ORCPT ); Fri, 15 Dec 2017 15:08:27 -0500 Received: by mail-ot0-f196.google.com with SMTP id q39so2338084otb.8 for ; Fri, 15 Dec 2017 12:08:27 -0800 (PST) In-Reply-To: <20171215091044.GE929@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: On December 15, 2017 1:10:44 AM PST, Andrew Lunn wrote: >On Thu, Dec 14, 2017 at 05:48:16PM -0800, Florian Fainelli wrote: >> Add an entry for the builtin PHYs present in the Broadcom BCM5395 >switch=2E This >> allows us to retrieve the PHY statistics among other things=2E > >> static struct phy_driver broadcom_drivers[] =3D { >> { >> =2Ephy_id =3D PHY_ID_BCM5411, >> @@ -679,6 +710,16 @@ static struct phy_driver broadcom_drivers[] =3D { >> =2Econfig_init =3D brcm_fet_config_init, >> =2Eack_interrupt =3D brcm_fet_ack_interrupt, >> =2Econfig_intr =3D brcm_fet_config_intr, >> +}, { >> + =2Ephy_id =3D PHY_ID_BCM5395, >> + =2Ephy_id_mask =3D 0xfffffff0, >> + =2Ename =3D "Broadcom BCM5395", >> + =2Eflags =3D PHY_IS_INTERNAL, >> + =2Efeatures =3D PHY_GBIT_FEATURES, >> + =2Eget_sset_count =3D bcm_phy_get_sset_count, >> + =2Eget_strings =3D bcm_phy_get_strings, >> + =2Eget_stats =3D bcm53xx_phy_get_stats, >> + =2Eprobe =3D bcm53xx_phy_probe, >> } }; > >Hi Florian > >Is this the only PHY supported by this driver which has statistics? I need to cross check with the various data sheets to be sure, but it is q= uite likely that all Gigabit capable PHYs listed above would also support t= he same statistics=2E In any case, this would be a follow on patch to this = one=2E Thanks! > > Andrew Hi Andrew, --=20 Florian