From: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Evgeniy Polyakov <zbr@ioremap.net>,
Christian Brauner <brauner@kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
"leon@kernel.org" <leon@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"socketcan@hartkopp.net" <socketcan@hartkopp.net>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 5/6] connector/cn_proc: Performance improvements
Date: Thu, 1 Jun 2023 16:38:04 +0000 [thread overview]
Message-ID: <B9B5E492-36A1-4ED5-97ED-1ED048F51FCF@oracle.com> (raw)
In-Reply-To: <20230601092533.05270ab1@kernel.org>
> On Jun 1, 2023, at 9:25 AM, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 31 Mar 2023 16:55:27 -0700 Anjali Kulkarni wrote:
>> +#define FILTER
>> +
>> +#ifdef FILTER
>> +#define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg) + \
>> + sizeof(struct proc_input))
>> +#else
>> #define NL_MESSAGE_SIZE (sizeof(struct nlmsghdr) + sizeof(struct cn_msg) + \
>> sizeof(int))
>> +#endif
>
> The #define FILTER and ifdefs around it need to go, this much I can
> tell you without understanding what it does :S We have the git history
> we don't need to keep dead code around.
The FILTER option is for backwards compatibility for those who may be using the proc connector today - so they do not need to immediately switch to using the new method - the example just shows the old method which does not break or need changes - do you still want me to remove the FILTER?
Anjali
next prev parent reply other threads:[~2023-06-01 16:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 23:55 [PATCH v4 0/6] Process connector bug fixes & enhancements Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 1/6] netlink: Reverse the patch which removed filtering Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-04-01 4:09 ` Jakub Kicinski
2023-04-01 18:24 ` Anjali Kulkarni
2023-04-01 19:12 ` Jakub Kicinski
2023-04-01 19:58 ` Anjali Kulkarni
2023-04-03 20:47 ` Jakub Kicinski
2023-04-02 2:32 ` Anjali Kulkarni
2023-04-03 20:50 ` Jakub Kicinski
2023-04-04 18:06 ` Anjali Kulkarni
2023-04-26 23:58 ` Anjali Kulkarni
2023-04-27 17:03 ` Jakub Kicinski
2023-05-11 16:04 ` Anjali Kulkarni
2023-06-01 16:15 ` Anjali Kulkarni
2023-06-01 16:24 ` Jakub Kicinski
2023-06-01 16:34 ` Anjali Kulkarni
2023-06-01 16:43 ` Jakub Kicinski
2023-06-01 16:49 ` Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 2/6] netlink: Add new netlink_release function Anjali Kulkarni
2023-04-01 4:08 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 3/6] connector/cn_proc: Add filtering to fix some bugs Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 4/6] connector/cn_proc: Test code for proc connector Anjali Kulkarni
2023-03-31 23:55 ` [PATCH v4 5/6] connector/cn_proc: Performance improvements Anjali Kulkarni
2023-06-01 16:25 ` Jakub Kicinski
2023-06-01 16:38 ` Anjali Kulkarni [this message]
2023-06-01 16:48 ` Jakub Kicinski
2023-06-01 16:53 ` Anjali Kulkarni
2023-06-01 17:15 ` Jakub Kicinski
2023-06-02 22:23 ` Anjali Kulkarni
2023-06-02 23:02 ` Jakub Kicinski
2023-03-31 23:55 ` [PATCH v4 6/6] connector/cn_proc: Allow non-root users access Anjali Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B9B5E492-36A1-4ED5-97ED-1ED048F51FCF@oracle.com \
--to=anjali.k.kulkarni@oracle.com \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=socketcan@hartkopp.net \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).