Re: [PATCH net-next 0/6] net: bcmgenet: PHY initialization rework

[Jaedon Shin <jaedon.shin@gmail.com>]

> On Jul 17, 2015, at 7:51 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
> Hi David, Petri, Jaedon,
> 
> This patch series reworks how we perform PHY initialization and resets in the
> GENET driver. Although this contains mostly fixes, some of the changes are a
> bit too intrusive to be backported to 'net' at the moment.
> 
> Some of the motivations behind these changes were to reduce the time spent in how
> performing MDIO transactions, since it is better to perform then when we have
> interrupts enabled. This reduces the bring-up time of GENET from ~600 msecs down
> to ~8 msecs, and about the same time for suspend/resume.
> 
> Since I do not currently have a system which is not DT-aware, can you (Petri,
> Jaedon) give this a try and confirm things keep working as expected?
> 
> Thanks!
> 

I tested your patch series on Broadcom 40nm set-top box platform that used
internal phy. I did not have the exact measurements. but I expect it to improve
on the interface-up or link-up time. and I compared the changes roughly from
kernel print time. please see below.

- before patching
[    1.865126] bcmgenet 10430000.ethernet eth0: Link is Down
[    3.941132] bcmgenet 10430000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx

- after patching
[    3.145127] bcmgenet 10430000.ethernet eth0: Link is Down
[    4.189140] bcmgenet 10430000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx

> Florian Fainelli (6):
>  net: bcmgenet: Remove excessive PHY reset
>  net: bcmgenet: Use correct dev_id for free_irq
>  net: bcmgenet: Power on integrated GPHY in bcmgenet_power_up()
>  net: bcmgenet: Determine PHY type before scanning MDIO bus
>  net: bcmgenet: Delay PHY initialization to bcmgenet_open()
>  net: bcmgenet: Remove init parameter from bcmgenet_mii_config
> 
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 33 +++++-----
> drivers/net/ethernet/broadcom/genet/bcmgenet.h |  5 +-
> drivers/net/ethernet/broadcom/genet/bcmmii.c   | 84 ++++++++++++--------------
> 3 files changed, 59 insertions(+), 63 deletions(-)
> 
> -- 
> 2.1.0
>