From: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
To: Bernard Metzler <BMT-OA+xvbQnYDHMbYB6QlFGEg@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: software iwarp stack update
Date: Thu, 16 Jun 2011 10:20:04 -0700 [thread overview]
Message-ID: <BANLkTi=2woNzF=GL3cT3NB_hye5JHfodMA@mail.gmail.com> (raw)
In-Reply-To: <OFB7458EEB.BFB8A4EE-ONC12578B1.004026D1-C12578B1.0041190E-Xeyd2O9EBijQT0dZR+AlfA@public.gmane.org>
> I was expecting there is an ib_device->uverbs_cmd_mask
> flag which siw does not set... Unfortunately, it is not
> completely clear to me when a command mask bit is available
> and when the OFA core strictly expects a function pointer.
> Maybe there is some redundancy/inconsistency?
The uverbs_cmd_mask controls which commands userspace
can send down. A kernel consumer does not go through the
code that checks this mask.
It does seem we are missing an IB_MANDATORY_FUNC
entry for modify_port in ib_device_check_mandatory; or on
the flip side we are missing a check of modify_port and a
-ENOSYS return... I guess modify_port does not really make
sense for iWARP so probably the second option is better.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-16 17:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 8:19 software iwarp stack update Bernard Metzler
[not found] ` <OF64770AFC.B48EBEF2-ONC12577A6.002CC793-C12577A6.002DC569-Xeyd2O9EBijQT0dZR+AlfA@public.gmane.org>
2010-09-22 20:35 ` Nicholas A. Bellinger
2010-09-22 20:42 ` Steve Wise
2010-09-23 15:25 ` Bernard Metzler
[not found] ` <1285187710.1849.82.camel-Y1+j5t8j3WgjMeEPmliV8E/sVC8ogwMJ@public.gmane.org>
2010-10-04 14:27 ` Software iWARP (SIW) patches Bernard Metzler
2010-10-04 16:30 ` Hefty, Sean
2011-06-04 18:01 ` software iwarp stack update Bart Van Assche
[not found] ` <BANLkTikUWpf4iAQT-9DwL_qSCEcY7CPN6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-05 17:39 ` Bernard Metzler
2011-06-15 15:43 ` Bernard Metzler
2011-06-15 16:32 ` Bart Van Assche
[not found] ` <BANLkTimmxN71ihGGXPH3JB1vGWyv1p-7mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-15 18:11 ` Roland Dreier
[not found] ` <OFC721DC15.CBE893E3-ONC12578B0.0053737C-C12578B0.00565784-Xeyd2O9EBijQT0dZR+AlfA@public.gmane.org>
2011-06-15 18:57 ` Bart Van Assche
[not found] ` <BANLkTimEGgKEMZd3qppOofN-Vj-u-PH-xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-16 11:51 ` Bernard Metzler
2011-06-16 16:54 ` Bart Van Assche
[not found] ` <OFB7458EEB.BFB8A4EE-ONC12578B1.004026D1-C12578B1.0041190E-Xeyd2O9EBijQT0dZR+AlfA@public.gmane.org>
2011-06-16 17:20 ` Roland Dreier [this message]
[not found] ` <BANLkTi=2woNzF=GL3cT3NB_hye5JHfodMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-16 18:06 ` Bart Van Assche
2011-06-17 14:23 ` Bernard Metzler
2011-06-18 16:35 ` Bart Van Assche
[not found] ` <BANLkTi=L057TZug2=nrFZTYdNoHLMvmBRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-18 23:45 ` Roland Dreier
2011-06-16 12:40 ` Software iWARP Stack - take 2 Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=2woNzF=GL3cT3NB_hye5JHfodMA@mail.gmail.com' \
--to=roland-bhel68plqrggvpxpguhicg@public.gmane.org \
--cc=BMT-OA+xvbQnYDHMbYB6QlFGEg@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).