From: "Sjur Brændeland" <sjurbren@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: CAIF transmit bug
Date: Sun, 22 May 2011 23:35:03 +0200 [thread overview]
Message-ID: <BANLkTi=DnD9eMiP_+H491T0ejXjYWAmBow@mail.gmail.com> (raw)
In-Reply-To: <20110519.174415.182212433770446975.davem@davemloft.net>
Hi Dave,
> net/caif/cfctrl.c:cfctrl_enum_req() does not check the return value of
> the ->transmit() method.
>
> The documentation for this method states that one error, ownership
> of the packet is transferred back to the caller, which means that we
> have a leak here.
>
> Please fix this bug.
The documentation was unfortunately outdated.
I just sent a patch-set including a fix for this.
Thank you for reviewing this.
Regards,
Sjur
prev parent reply other threads:[~2011-05-22 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 21:44 CAIF transmit bug David Miller
2011-05-22 21:35 ` Sjur Brændeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=DnD9eMiP_+H491T0ejXjYWAmBow@mail.gmail.com' \
--to=sjurbren@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).