* CAIF transmit bug
@ 2011-05-19 21:44 David Miller
2011-05-22 21:35 ` Sjur Brændeland
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2011-05-19 21:44 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev
net/caif/cfctrl.c:cfctrl_enum_req() does not check the return value of
the ->transmit() method.
The documentation for this method states that one error, ownership
of the packet is transferred back to the caller, which means that we
have a leak here.
Please fix this bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: CAIF transmit bug
2011-05-19 21:44 CAIF transmit bug David Miller
@ 2011-05-22 21:35 ` Sjur Brændeland
0 siblings, 0 replies; 2+ messages in thread
From: Sjur Brændeland @ 2011-05-22 21:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi Dave,
> net/caif/cfctrl.c:cfctrl_enum_req() does not check the return value of
> the ->transmit() method.
>
> The documentation for this method states that one error, ownership
> of the packet is transferred back to the caller, which means that we
> have a leak here.
>
> Please fix this bug.
The documentation was unfortunately outdated.
I just sent a patch-set including a fix for this.
Thank you for reviewing this.
Regards,
Sjur
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-22 21:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 21:44 CAIF transmit bug David Miller
2011-05-22 21:35 ` Sjur Brændeland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).