From: "Michał Mirosław" <mirqus@gmail.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Patrick McHardy <kaber@trash.net>,
rusty@rustcorp.com.au, mst@redhat.com,
Eric Dumazet <eric.dumazet@gmail.com>,
krkumar2@in.ibm.com, mirq-linux@rere.qmqm.pl, joe@perches.com
Subject: Re: [PATCH net-next 2/3] net: fullly using NETIF_F_GSO_SOFTWARE macros and NETIF_F_SOFT_FEATURES
Date: Fri, 22 Apr 2011 13:39:28 +0200 [thread overview]
Message-ID: <BANLkTi=X_LvQ1-SA5-P6rs3akY2tGbHryQ@mail.gmail.com> (raw)
In-Reply-To: <4DB16181.9010306@cn.fujitsu.com>
2011/4/22 Shan Wei <shanwei@cn.fujitsu.com>:
> Fullly using NETIF_F_GSO_SOFTWARE and NETIF_F_SOFT_FEATURES.
> And some code style tuning. Just compile test.
[...]
Plese don't replace feature sets with masks of them like that. The
values are the same, but it will confuse readers as to the meaning of
the code.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-04-22 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 11:07 [PATCH net-next 2/3] net: fullly using NETIF_F_GSO_SOFTWARE macros and NETIF_F_SOFT_FEATURES Shan Wei
2011-04-22 11:39 ` Michał Mirosław [this message]
2011-04-28 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=X_LvQ1-SA5-P6rs3akY2tGbHryQ@mail.gmail.com' \
--to=mirqus@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=krkumar2@in.ibm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).