From: Jacek Luczak <difrost.kernel@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wei Yongjun <yjwei@cn.fujitsu.com>,
netdev@vger.kernel.org, Vlad Yasevich <vladislav.yasevich@hp.com>
Subject: Re: [PATCH] SCTP: fix race between sctp_bind_addr_free() and sctp_bind_addr_conflict()
Date: Wed, 18 May 2011 13:58:14 +0200 [thread overview]
Message-ID: <BANLkTi=_ob1iM4yB3m3NoiPccSYd8koABQ@mail.gmail.com> (raw)
In-Reply-To: <1305718902.2991.3.camel@edumazet-laptop>
2011/5/18 Eric Dumazet <eric.dumazet@gmail.com>:
> Le mercredi 18 mai 2011 à 13:01 +0200, Jacek Luczak a écrit :
>
>> @Eric, if you will take a look into the code you might notice
>> that there are few places where list operations could be
>> optimised and the main question here is do we really care
>> to have the data ,,safe'' so that things like that won't popup.
>> The good example can be the set of _local_ functions.
There should be a vertical space here ...
>> Ahhh... and I'm aware of how tricky can be abuse of RCU.
>
> I took a quick look at existing rcu_read_lock() uses in sctp and did not
> find other problems [or optimizations if you prefer this point of view].
> Please elaborate.
... so that the last line does not have any connection with what I've
wrote above.
I get your point Eric so you don't really have to prove it - if you still need.
-jacek
next prev parent reply other threads:[~2011-05-18 11:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 7:01 [PATCH] SCTP: fix race between sctp_bind_addr_free() and sctp_bind_addr_conflict() Jacek Luczak
2011-05-18 7:48 ` Eric Dumazet
2011-05-18 8:06 ` Jacek Luczak
2011-05-18 8:29 ` Eric Dumazet
2011-05-18 9:02 ` Wei Yongjun
2011-05-18 11:01 ` Jacek Luczak
2011-05-18 11:41 ` Eric Dumazet
2011-05-18 11:58 ` Jacek Luczak [this message]
2011-05-18 12:33 ` Vladislav Yasevich
2011-05-18 12:47 ` Jacek Luczak
2011-05-18 12:50 ` Eric Dumazet
2011-05-18 13:11 ` Jacek Luczak
2011-05-18 13:20 ` Eric Dumazet
2011-05-18 13:32 ` Vladislav Yasevich
2011-05-18 13:39 ` Jacek Luczak
2011-05-18 12:06 ` Jacek Luczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=_ob1iM4yB3m3NoiPccSYd8koABQ@mail.gmail.com' \
--to=difrost.kernel@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).