From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ciprian Docan <docan@eden.rutgers.edu>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
"Rafael, J. Wysocki" <rjw@sisk.pl>, Greg KH <gregkh@suse.de>
Subject: Re: Suspend/resume - slow resume
Date: Mon, 18 Apr 2011 12:51:40 -0700 [thread overview]
Message-ID: <BANLkTi=dke10HougmiQn9hSF15nK0B8mdA@mail.gmail.com> (raw)
In-Reply-To: <Pine.SOC.4.64.1104181519490.1320@er3.rutgers.edu>
On Mon, Apr 18, 2011 at 12:27 PM, Ciprian Docan <docan@eden.rutgers.edu> wrote:
>
> Linus - I applied your patch and attached the diff between output of dmesg
> before and after the patch as resume_timing.diff. This patch alone does not
> seem to fix the issue;
Ok, that just means that the error return from call_usermodehelper()
gets lost somewhere along the way to kobject_uevent(). Or that I
misread the whole thing.
> however, applying Francois's patch in addition to
> yours make the resume smooth.
Well, Francois' patch on its own should already have fixed it for you,
and made the whole issue moot.
Francois' patch is fine and improves on things, I only had a few
arguments with it. The problems I think it had were really about some
rather special cases.
Linus
next prev parent reply other threads:[~2011-04-18 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SOC.4.64.1104150931390.1320@er3.rutgers.edu>
[not found] ` <BANLkTinO+HFq+Mgg1aUz9V==zYs7qSBtDw@mail.gmail.com>
[not found] ` <Pine.SOC.4.64.1104151122330.1320@er3.rutgers.edu>
2011-04-15 16:14 ` Suspend/resume - slow resume Linus Torvalds
2011-04-17 10:17 ` Francois Romieu
2011-04-17 16:42 ` Linus Torvalds
2011-04-18 18:08 ` Francois Romieu
2011-04-18 18:49 ` Linus Torvalds
2011-04-18 19:25 ` Ben Hutchings
2011-04-18 19:27 ` Ciprian Docan
2011-04-18 19:51 ` Linus Torvalds [this message]
2011-04-20 18:16 ` Francois Romieu
2011-04-20 18:51 ` Ciprian Docan
2011-04-20 19:52 ` Francois Romieu
2011-04-20 19:10 ` Ciprian Docan
2011-04-20 19:53 ` Francois Romieu
2011-04-21 2:07 ` Ciprian Docan
2011-04-21 13:02 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=dke10HougmiQn9hSF15nK0B8mdA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=docan@eden.rutgers.edu \
--cc=gregkh@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).