From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Suspend/resume - slow resume Date: Mon, 18 Apr 2011 12:51:40 -0700 Message-ID: References: <20110417101731.GA17986@electric-eye.fr.zoreil.com> <20110418180813.GA18469@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Francois Romieu , netdev@vger.kernel.org, Linux Kernel Mailing List , Len Brown , Pavel Machek , "Rafael, J. Wysocki" , Greg KH To: Ciprian Docan Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Apr 18, 2011 at 12:27 PM, Ciprian Docan wrote: > > Linus - I applied your patch and attached the diff between output of dmesg > before and after the patch as resume_timing.diff. This patch alone does not > seem to fix the issue; Ok, that just means that the error return from call_usermodehelper() gets lost somewhere along the way to kobject_uevent(). Or that I misread the whole thing. > however, applying Francois's patch in addition to > yours make the resume smooth. Well, Francois' patch on its own should already have fixed it for you, and made the whole issue moot. Francois' patch is fine and improves on things, I only had a few arguments with it. The problems I think it had were really about some rather special cases. Linus