netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michał Mirosław" <mirqus@gmail.com>
To: Amit Salecha <amit.salecha@qlogic.com>
Cc: Marc Haber <mh+netdev@zugschlus.de>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Ameen Rahman <ameen.rahman@qlogic.com>,
	Rajesh Borundia <rajesh.borundia@qlogic.com>
Subject: Re: Netxen packet loss with VLANs and LRO (was: [PATCH] netxen: fix LRO disable warning)
Date: Tue, 5 Apr 2011 12:38:08 +0200	[thread overview]
Message-ID: <BANLkTi=i7A+J2WKPgATpH6ekFAeb-sn+UQ@mail.gmail.com> (raw)
In-Reply-To: <99737F4847ED0A48AECC9F4A1974A4B80FD10E8E3C@MNEXMB2.qlogic.org>

2011/4/5 Amit Salecha <amit.salecha@qlogic.com>:
>> On Mon, Mar 21, 2011 at 03:37:08AM -0700, Amit Kumar Salecha wrote:
>> > netxen_nic_set_flags() rejects data if other flag than ETH_FLAG_LRO
>> is set.
>> > Driver also supports NETIF_F_HW_VLAN_TX.
>> > Now compare data with ethtool_op_get_flags(), to get all supported
>> features.
[...]
>> My ethtool doesn't allow me to influence the LRO setting alone - it is
>> disabled when I set rx off but doesn't come on again when rx is set to
>> on again. So, ethtool -K rx off, ethtool -K rx on fixes the issue.
> If rx csum is disabled, LRO will be disable. LRO won't be enabled automatically if you enable rx csum.
> You need to explicitly enable LRO.

This will change once the driver is converted to hw_features.

Best Regards,
Michał Mirosław

  reply	other threads:[~2011-04-05 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21 10:37 [PATCH] netxen: fix LRO disable warning Amit Kumar Salecha
2011-03-21 10:47 ` Eric Dumazet
2011-03-21 11:13   ` Amit Salecha
2011-03-28  1:08     ` David Miller
2011-03-28  5:33       ` Amit Salecha
2011-03-28  5:17         ` Stanislaw Gruszka
2011-03-28  6:31           ` David Miller
2011-03-28  6:29         ` David Miller
2011-04-03 19:05 ` Netxen packet loss with VLANs and LRO (was: [PATCH] netxen: fix LRO disable warning) Marc Haber
2011-04-05  5:38   ` Amit Salecha
2011-04-05 10:38     ` Michał Mirosław [this message]
2011-04-05 12:41     ` Marc Haber
2011-04-05 13:15       ` Amit Salecha
2011-04-05 15:18         ` Marc Haber
2011-04-05 15:46           ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=i7A+J2WKPgATpH6ekFAeb-sn+UQ@mail.gmail.com' \
    --to=mirqus@gmail.com \
    --cc=ameen.rahman@qlogic.com \
    --cc=amit.salecha@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=mh+netdev@zugschlus.de \
    --cc=netdev@vger.kernel.org \
    --cc=rajesh.borundia@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).