From: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>,
Octavian Purdila <tavi@cs.pub.ro>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [v3 00/39] faster tree-based sysctl implementation
Date: Mon, 23 May 2011 08:59:39 +0300 [thread overview]
Message-ID: <BANLkTik0NZSC84-_-j0LyyzSJykH-VxGXw@mail.gmail.com> (raw)
In-Reply-To: <m14o4mavod.fsf@fess.ebiederm.org>
On Mon, May 23, 2011 at 7:27 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
> I will mention a couple of nits I noticed while I was skimming through
> your patches.
> - There can be multiple proc superblocks and thus multiple inodes
> referring to the same /proc/sys file, if there are multiple pid
> namespaces.
OK. I'll revert the patch that make converts an int counter into an u8
and post an update. I guess this is what you were referring to.
https://github.com/luciang/linux-2.6-new-sysctl/commit/b7a547b8ce7484ae22eea34a860f674fcb19c11b
> - I have a hope to move /proc/sys into /proc/<pid>/sys so we don't have
> to look at current to determine the namespace we want to display.
> That would allow the deeply magic sysctl_is_seen check to be removed
> from proc_sys_compare. That is not your problem, but of an
> explanation why the namespaces are passed through.
OK, I'll go an change things to pass the current namespace as it were
before my changes.
Thank you.
--
.
..: Lucian
next prev parent reply other threads:[~2011-05-23 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 1:56 [v3 00/39] faster tree-based sysctl implementation Lucian Adrian Grijincu
2011-05-23 4:27 ` Eric W. Biederman
2011-05-23 5:59 ` Lucian Adrian Grijincu [this message]
2011-05-23 6:37 ` Lucian Adrian Grijincu
2011-05-23 9:32 ` Eric W. Biederman
2011-05-23 13:26 ` Lucian Adrian Grijincu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik0NZSC84-_-j0LyyzSJykH-VxGXw@mail.gmail.com \
--to=lucian.grijincu@gmail.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tavi@cs.pub.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).