From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Russell King <linux@arm.linux.org.uk>,
Finn Thain <fthain@telegraphics.com.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-m68k@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
stable@kernel.org
Subject: Re: [PATCH 3/3] ne-h8300: Fix regression caused during net_device_ops conversion
Date: Thu, 12 May 2011 21:16:06 +0200 [thread overview]
Message-ID: <BANLkTik1_YpK-4X_+Axs9Zicne_zGVoGHg@mail.gmail.com> (raw)
In-Reply-To: <1305227500-15595-4-git-send-email-geert@linux-m68k.org>
On Thu, May 12, 2011 at 21:11, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> From: Geert Uytterhoeven <geert@chicken.sonytel.be>
Sorry, the above line is bogus. Please remove it.
> Changeset dcd39c90290297f6e6ed8a04bb20da7ac2b043c5 ("ne-h8300: convert to
> net_device_ops") broke ne-h8300 by adding 8390.o to the link. That
> meant that lib8390.c was included twice, once in ne-h8300.c and once in
> 8390.c, subject to different macros. This patch reverts that by
> avoiding the wrappers in 8390.c.
>
> Fix based on commits 217cbfa856dc1cbc2890781626c4032d9e3ec59f ("mac8390:
> fix regression caused during net_device_ops conversion") and
> 4e0168fa4842e27795a75b205a510f25b62181d9 ("mac8390: fix build with
> NET_POLL_CONTROLLER").
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: stable@kernel.org
> ---
> drivers/net/Makefile | 2 +-
> drivers/net/ne-h8300.c | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 4d2f094..e5a7375 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -144,7 +144,7 @@ obj-$(CONFIG_NE3210) += ne3210.o 8390.o
> obj-$(CONFIG_SB1250_MAC) += sb1250-mac.o
> obj-$(CONFIG_B44) += b44.o
> obj-$(CONFIG_FORCEDETH) += forcedeth.o
> -obj-$(CONFIG_NE_H8300) += ne-h8300.o 8390.o
> +obj-$(CONFIG_NE_H8300) += ne-h8300.o
> obj-$(CONFIG_AX88796) += ax88796.o
> obj-$(CONFIG_BCM63XX_ENET) += bcm63xx_enet.o
> obj-$(CONFIG_FTMAC100) += ftmac100.o
> diff --git a/drivers/net/ne-h8300.c b/drivers/net/ne-h8300.c
> index 30be8c6..7298a34 100644
> --- a/drivers/net/ne-h8300.c
> +++ b/drivers/net/ne-h8300.c
> @@ -167,7 +167,7 @@ static void cleanup_card(struct net_device *dev)
> #ifndef MODULE
> struct net_device * __init ne_probe(int unit)
> {
> - struct net_device *dev = alloc_ei_netdev();
> + struct net_device *dev = ____alloc_ei_netdev(0);
> int err;
>
> if (!dev)
> @@ -197,15 +197,15 @@ static const struct net_device_ops ne_netdev_ops = {
> .ndo_open = ne_open,
> .ndo_stop = ne_close,
>
> - .ndo_start_xmit = ei_start_xmit,
> - .ndo_tx_timeout = ei_tx_timeout,
> - .ndo_get_stats = ei_get_stats,
> - .ndo_set_multicast_list = ei_set_multicast_list,
> + .ndo_start_xmit = __ei_start_xmit,
> + .ndo_tx_timeout = __ei_tx_timeout,
> + .ndo_get_stats = __ei_get_stats,
> + .ndo_set_multicast_list = __ei_set_multicast_list,
> .ndo_validate_addr = eth_validate_addr,
> - .ndo_set_mac_address = eth_mac_addr,
> + .ndo_set_mac_address = eth_mac_addr,
> .ndo_change_mtu = eth_change_mtu,
> #ifdef CONFIG_NET_POLL_CONTROLLER
> - .ndo_poll_controller = ei_poll,
> + .ndo_poll_controller = __ei_poll,
> #endif
> };
>
> @@ -637,7 +637,7 @@ int init_module(void)
> int err;
>
> for (this_dev = 0; this_dev < MAX_NE_CARDS; this_dev++) {
> - struct net_device *dev = alloc_ei_netdev();
> + struct net_device *dev = ____alloc_ei_netdev(0);
> if (!dev)
> break;
> if (io[this_dev]) {
> --
> 1.7.0.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2011-05-12 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 19:11 [PATCH 0/3] Fix 8390 regressions Geert Uytterhoeven
2011-05-12 19:11 ` [PATCH 1/3] zorro8390: Fix regression caused during net_device_ops conversion Geert Uytterhoeven
2011-05-12 19:11 ` [PATCH 2/3] hydra: " Geert Uytterhoeven
2011-05-12 19:15 ` Geert Uytterhoeven
2011-05-12 19:11 ` [PATCH 3/3] ne-h8300: " Geert Uytterhoeven
2011-05-12 19:16 ` Geert Uytterhoeven [this message]
2011-05-12 21:02 ` [PATCH 0/3] Fix 8390 regressions David Miller
2011-05-13 5:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik1_YpK-4X_+Axs9Zicne_zGVoGHg@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stable@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).