netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Fleming <afleming@gmail.com>
To: ANDY KENNEDY <ANDY.KENNEDY@adtran.com>
Cc: michael@riesch.at, netdev@vger.kernel.org
Subject: Re: SMSC 8720a/MDIO/PHY help.
Date: Fri, 15 Apr 2011 15:29:55 -0500	[thread overview]
Message-ID: <BANLkTik7xeMnx0S2m0easY0hVT_UmomjzA@mail.gmail.com> (raw)
In-Reply-To: <9AC3F0E75060224C8BBC5BA2DDC8853A1FA8E8D4@EXV1.corp.adtran.com>

On Wed, Apr 13, 2011 at 4:38 PM, ANDY KENNEDY <ANDY.KENNEDY@adtran.com> wrote:
>> -----Original Message-----
>> From: Michael Riesch [mailto:michael@riesch.at]
>> Sent: Wednesday, April 13, 2011 4:19 PM
>> To: netdev@vger.kernel.org
>> Cc: ANDY KENNEDY
>> Subject: Re: SMSC 8720a/MDIO/PHY help.
>>
>>
>> > If you have an idea of something for me to try, I'd love to
>> entertain
>> > it.
>>
>> I am rather new to PHYLIB, but these are my ideas:
>>
>>  1) make sure phy_connect is executed (AFIAK called by MDIO bus
>> driver)
>
> Going through the phy.txt doc under Documentation/networking:
> PHY Abstraction Layer
> (Updated 2008-04-08)
> though it may be a bit out-of-date, I did see what you are talking about.  What I'm hung up on at the moment is the behavior of adjust_link().  It appears that I only need to start the queues, though I don’t know.
>
>>
>>  2) maybe you need to call phy_start / phy_stop (AFAIK from the PHY
>> driver's open / close function)
>
> Currently, when I do this I only get the call to adjust_link() over and over again.


...this means that the state machine is running.  The PHY is polling
every couple seconds to report the current state. It calls
adjust_link() to keep the net_device up-to-date on that state. What
other behavior are you expecting to see?


Andy

  parent reply	other threads:[~2011-04-15 20:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 21:46 SMSC 8720a/MDIO/PHY help ANDY KENNEDY
2011-04-13 21:19 ` Michael Riesch
2011-04-13 21:38   ` ANDY KENNEDY
2011-04-14  4:08     ` ANDY KENNEDY
2011-04-14 21:39       ` Michael Riesch
2011-04-15 20:36       ` Andy Fleming
2011-04-15 20:29     ` Andy Fleming [this message]
2011-04-15 20:53       ` ANDY KENNEDY
2011-04-15 21:02         ` Andy Fleming
2011-04-15 21:17           ` ANDY KENNEDY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTik7xeMnx0S2m0easY0hVT_UmomjzA@mail.gmail.com \
    --to=afleming@gmail.com \
    --cc=ANDY.KENNEDY@adtran.com \
    --cc=michael@riesch.at \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).