Re: [PATCH net-next 2/2 V3] net: driver: use NETIF_F_GSO_SOFTWARE masks directly

Re: [PATCH net-next 2/2 V3] net: driver: use NETIF_F_GSO_SOFTWARE masks directly

[Michał Mirosław]

2011/5/11 Shan Wei <shanwei@cn.fujitsu.com>:
> For loopback device can support any offload, so directly using
> NETIF_F_GSO_SOFTWARE offload mask is enough safe.
> And as Michał Mirosław suggested, add NETIF_F_HIGHDMA to hw_features.
>
>
> For virtio_net driver, safely using NETIF_F_GSO_SOFTWARE offload mask for bit operation.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> ---
>  drivers/net/loopback.c   |   16 +++++-----------
>  drivers/net/virtio_net.c |    3 ++-
>  2 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
> index 4ce9e5f..e6cccec 100644
> --- a/drivers/net/loopback.c
> +++ b/drivers/net/loopback.c
> @@ -165,17 +165,11 @@ static void loopback_setup(struct net_device *dev)
>        dev->type               = ARPHRD_LOOPBACK;      /* 0x0001*/
>        dev->flags              = IFF_LOOPBACK;
>        dev->priv_flags        &= ~IFF_XMIT_DST_RELEASE;
> -       dev->hw_features        = NETIF_F_ALL_TSO | NETIF_F_UFO;
> -       dev->features           = NETIF_F_SG | NETIF_F_FRAGLIST
> -               | NETIF_F_ALL_TSO
> -               | NETIF_F_UFO
> -               | NETIF_F_NO_CSUM
> -               | NETIF_F_RXCSUM
> -               | NETIF_F_HIGHDMA
> -               | NETIF_F_LLTX
> -               | NETIF_F_NETNS_LOCAL
> -               | NETIF_F_VLAN_CHALLENGED
> -               | NETIF_F_LOOPBACK;
> +       dev->hw_features        = NETIF_F_GSO_SOFTWARE | NETIF_F_HIGHDMA;
> +       dev->features           = dev->hw_features | NETIF_F_SG
> +               | NETIF_F_FRAGLIST | NETIF_F_NO_CSUM | NETIF_F_RXCSUM
> +               | NETIF_F_LLTX | NETIF_F_NETNS_LOCAL
> +               | NETIF_F_VLAN_CHALLENGED | NETIF_F_LOOPBACK;
>        dev->ethtool_ops        = &loopback_ethtool_ops;
>        dev->header_ops         = &eth_header_ops;
>        dev->netdev_ops         = &loopback_ops;
[...]

Looks ok. For loopback, more features are actually changeable - only
last 4 are really forced here.

Best Regards,
Michał Mirosław