From: Jon Mason <jon.mason@myri.com>
To: jeffrey.t.kirsher@intel.com
Cc: Joe Perches <joe@perches.com>, netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Jan Engelhardt <jengelh@medozas.de>,
Andrew Gallatin <gallatin@myri.com>
Subject: Re: [RFC] Moving files around in drivers/net
Date: Mon, 20 Jun 2011 10:23:07 -0500 [thread overview]
Message-ID: <BANLkTikDM4OWOb=f5qdyWhZu4se4CWHYfw@mail.gmail.com> (raw)
In-Reply-To: <1308535174.22851.26.camel@jtkirshe-mobl>
[snip]
>> > commit 83df87d655e25119eafaeb4225bc5eedaa82c6e0
>> > Author: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> > Date: Fri May 13 02:24:46 2011 -0700
>> >
>> > myri*: Move the Myricom drivers
>> >
>> > Move the Myricom drivers into drivers/net/ethernet/myricom/ and
>> make
>> > the necessary Kconfig and Makefile changes.
>> >
>> > CC: Andrew Gallatin <gallatin@myri.com>
>> > CC: Brice Goglin <brice@myri.com>
>> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> >
>> > MAINTAINERS | 2 +-
>> > drivers/net/Kconfig | 35
>> -------------
>> > drivers/net/Makefile | 3 -
>> > drivers/net/ethernet/Kconfig | 1 +
>> > drivers/net/ethernet/Makefile | 1 +
>> > drivers/net/ethernet/myricom/Kconfig | 51
>> ++++++++++++++++++++
>> > drivers/net/ethernet/myricom/Makefile | 6 ++
>> > .../net/{ => ethernet/myricom}/myri10ge/Makefile | 0
>> > .../net/{ => ethernet/myricom}/myri10ge/myri10ge.c | 0
>> > .../{ => ethernet/myricom}/myri10ge/myri10ge_mcp.h | 0
>> > .../myricom}/myri10ge/myri10ge_mcp_gen_header.h | 0
>> > drivers/net/{ => ethernet/myricom}/myri_sbus.c | 0
>> > drivers/net/{ => ethernet/myricom}/myri_sbus.h | 0
>>
>> /me puts on Myricom hat
>>
>> I believe we want to put the driver above in the sbus/legacy
>> directory. Better yet, move this driver to /dev/null. There is no
>> possibility of ethernet mode on this adapter, so it's Myrinet only.
>> It won't inter-op with modern versions of Myrinet, and thus can only
>> work with legacy adapters. There are no drivers for the PCI version
>> of this adapter, so it only can work on ~15year old hardware. It's
>> long in the tooth, let's take it to the knackers.
>>
>> Thanks,
>> Jon
>
> That sounds good. Since I am not the maintainer or author of the
> driver, I think such a move should come from Myricom. I can drop the
> move of myri_sbus.[ch] from my patches to organize the driver/net/
> directory.
I'll submit a patch shortly to remove it. Assuming that it will be
rejected, I'd recommend putting myri_sbus.* into
drivers/net/myrinet/
similar to how you have an ethernet directory.
Thanks,
Jon
next prev parent reply other threads:[~2011-06-20 15:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 19:30 [RFC] Moving files around in drivers/net Joe Perches
2011-06-01 19:53 ` Jeff Kirsher
2011-06-01 20:01 ` Joe Perches
2011-06-15 18:38 ` Jeff Kirsher
2011-06-15 20:35 ` Andy Gospodarek
2011-06-16 1:10 ` Joe Perches
2011-06-16 3:34 ` Po-Yu Chuang
2011-06-20 1:42 ` Jeff Kirsher
2011-06-16 5:05 ` Sathya.Perla
2011-06-20 1:48 ` Jeff Kirsher
2011-06-16 14:14 ` Jon Mason
2011-06-20 1:51 ` Jeff Kirsher
2011-06-16 15:03 ` Jon Mason
2011-06-20 1:59 ` Jeff Kirsher
2011-06-20 15:23 ` Jon Mason [this message]
2011-06-23 13:30 ` Giuseppe CAVALLARO
2011-06-24 3:56 ` Jeff Kirsher
2011-06-20 2:25 ` Jeff Kirsher
2011-06-20 3:22 ` Ben Hutchings
2011-06-20 4:02 ` Jeff Kirsher
2011-06-20 5:23 ` Jan Engelhardt
2011-06-20 6:01 ` Joe Perches
2011-06-01 21:07 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikDM4OWOb=f5qdyWhZu4se4CWHYfw@mail.gmail.com' \
--to=jon.mason@myri.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jengelh@medozas.de \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).