From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Gross Subject: Re: [PATCH net-next-2.6] vlan: remove one synchronize_net() call Date: Mon, 9 May 2011 10:30:25 -0700 Message-ID: References: <1304948155.3342.32.camel@edumazet-laptop> <1304952044.3342.42.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , Ben Greear , Patrick McHardy , netdev , "Paul E. McKenney" , =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= To: Eric Dumazet Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:62167 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445Ab1EIRaq convert rfc822-to-8bit (ORCPT ); Mon, 9 May 2011 13:30:46 -0400 Received: by qyk7 with SMTP id 7so1159793qyk.19 for ; Mon, 09 May 2011 10:30:45 -0700 (PDT) In-Reply-To: <1304952044.3342.42.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, May 9, 2011 at 7:40 AM, Eric Dumazet w= rote: > At VLAN dismantle phase, unregister_vlan_dev() makes one > synchronize_net() call after vlan_group_set_device(grp, vlan_id, NULL= ). > > This call can be safely removed because we are calling > unregister_netdevice_queue() to queue device for deletion, and this > process needs at least one rcu grace period to complete. > > Signed-off-by: Eric Dumazet > Cc: Ben Greear > Cc: Patrick McHardy > Cc: Paul E. McKenney > Cc: Jesse Gross > Cc: Micha=C5=82 Miros=C5=82aw Acked-by: Jesse Gross