From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Tom Herbert <therbert@google.com>
Subject: Re: [PATCH net-next] net: fix skb_add_data_nocache() to calc csum correctly
Date: Thu, 7 Apr 2011 14:05:09 +0200 [thread overview]
Message-ID: <BANLkTikFocF1oc4AbJFTVW3_rHj3WEersg@mail.gmail.com> (raw)
[QUOTE]
From: Tom Herbert <therbert@google.com>
Date: Wed, 6 Apr 2011 21:50:55 -0700
> Nice catch.
>
> Acked-by: Tom Herbert <therbert@google.com>
>
> On Wed, Apr 6, 2011 at 9:40 PM, Wei Yongjun <yjwei@cn.fujitsu.com> wrote:
>> commit c6e1a0d12ca7b4f22c58e55a16beacfb7d3d8462 broken the calc
>> (net: Allow no-cache copy from user on transmit)
>> of checksum, which may cause some tcp packets be dropped because
>> incorrect checksum. ssh does not work under today's net-next-2.6
>> tree.
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied, thanks everyone.
[/QUOTE]
With reference to my asking in [1] feel free to add:
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
- Sedat -
[1] http://marc.info/?l=linux-netdev&m=130217337305798&w=2
next reply other threads:[~2011-04-07 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 12:05 Sedat Dilek [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-07 4:40 [PATCH net-next] net: fix skb_add_data_nocache() to calc csum correctly Wei Yongjun
2011-04-07 4:50 ` Tom Herbert
2011-04-07 6:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikFocF1oc4AbJFTVW3_rHj3WEersg@mail.gmail.com \
--to=sedat.dilek@googlemail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
--cc=therbert@google.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).