netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory
Date: Tue, 24 May 2011 22:00:23 +0800	[thread overview]
Message-ID: <BANLkTikT2HJyGb_4BOF+Ds1AAcJV+HVQ-w@mail.gmail.com> (raw)
In-Reply-To: <20110523151336.GF21309@gospo.rdu.redhat.com>

On Mon, May 23, 2011 at 11:13 PM, Andy Gospodarek <andy@greyhouse.net> wrote:
> On Mon, May 23, 2011 at 08:45:14PM +0800, Américo Wang wrote:
>> Hello, Jay, Andy,
>>
>> Is there any peculiar reason that bonding code has to stay
>> in drivers/net/ directory?
>>
>> Since bonding and bridge are somewhat similar, both of
>> which are used to "bond" two or more devices into one,
>> and bridge code is already in net/bridge/, so I think it also
>> makes sense to move bonding code into net/bonding/ too.
>>
>> This could also help to grep the source more easily. :)
>>
>> What do you think about the patch below?
>> (Note, this patch is against net-next-2.6.)
>>
>
> I would rather keep the code for bonding in drivers/net since it is
> really a pure device (though not directly tied to any specific
> hardware) rather than a device + forwarding or management code.

Is this a reason strong enough to leave it to drivers/net/ ?
I think it is generic enough to be moved to net/ directory... :-/

>
> It has bothered me for a long time that the code just to manage the VLAN
> and bridge devices sits outside of drivers/net, but I've never proposed
> a patch to move the files as I suspect the maintainers of that code
> would like to keep it all together.  Maybe it is time to do that.
>

You mean move net/8021q/ to drivers/net/8021q/ ?

Thanks!

  reply	other threads:[~2011-05-24 14:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 12:45 [RFC Patch] bonding: move to net/ directory Américo Wang
2011-05-23 15:13 ` Andy Gospodarek
2011-05-24 14:00   ` Américo Wang [this message]
2011-05-24 15:03     ` Andy Gospodarek
2011-05-25 12:32       ` Américo Wang
2011-05-25 15:01         ` Neil Horman
2011-05-26  9:11           ` Américo Wang
2011-05-26 13:38             ` Neil Horman
2011-05-24 16:33     ` Neil Horman
2011-05-25 12:43       ` Américo Wang
2011-05-25 15:20         ` Neil Horman
2011-05-26  9:32           ` Américo Wang
2011-05-26 13:50             ` Neil Horman
2011-05-26 14:25               ` Michał Mirosław
2011-06-06 16:34                 ` Américo Wang
2011-06-06 16:50                   ` Joe Perches
2011-06-06 17:04                     ` Eric Dumazet
2011-06-06 17:20                       ` Joe Perches
2011-06-06 17:31                         ` Jeff Kirsher
2011-06-06 20:11                         ` Ben Hutchings
2011-06-06 17:31                     ` Jeff Kirsher
2011-06-18  2:48                       ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikT2HJyGb_4BOF+Ds1AAcJV+HVQ-w@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).