Re: [PATCH 2/9] net-ethtool: Convert (hw_/vlan_/wanted_)features fields from u32 type to u64.

["Michał Mirosław" <mirqus@gmail.com>]

2011/4/23 Mahesh Bandewar <maheshb@google.com>:
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> ---
>  include/linux/ethtool.h |   26 +++++++------
>  net/core/ethtool.c      |   89 ++++++++++++++++------------------------------
>  2 files changed, 45 insertions(+), 70 deletions(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 9de3127..71e8a02 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -605,10 +605,10 @@ struct ethtool_flash {
>  * @never_changed: mask of features not changeable for any device
>  */
>  struct ethtool_get_features_block {
> -       __u32   available;
> -       __u32   requested;
> -       __u32   active;
> -       __u32   never_changed;
> +       __u64   available;
> +       __u64   requested;
> +       __u64   active;
> +       __u64   never_changed;
>  };
[...]

Please don't do it like this. G/SFEATURES were prepared to handle
multiple words when needed. This means that it's enough to just split
the u64 into two u32 sets represented in ethtool_get/set_features.

Best Regards,
Michał Mirosław