From: "Michał Mirosław" <mirqus@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Linux Kernel Network Developers" <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Jay Vosburgh" <fubar@us.ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory
Date: Thu, 26 May 2011 16:25:16 +0200 [thread overview]
Message-ID: <BANLkTikrsr5sZ4aZ5aEmfBSvPE0mEL8g0g@mail.gmail.com> (raw)
In-Reply-To: <20110526135053.GB12617@hmsreliant.think-freely.org>
2011/5/26 Neil Horman <nhorman@tuxdriver.com>:
> On Thu, May 26, 2011 at 05:32:08PM +0800, Américo Wang wrote:
>> I don't think other drivers are supposed to use this function to register
>> a packet handler, which is an important difference from my view.
> Note you just referred to the bridge/bond and vlan code as 'drivers' :). And
> why is that function the gating factor? Why not register_netdev? or
> netif_receive_skb or dev_add_pack? They all relate to the creation of device
> interface and the reception of network data.
>
> The fact is, bonding/bridging/vlans/tunnels/etc all have aspects that
> make them more than just drivers. They are where they are for a myrriad of
> reasons. Moving them around changes their location, but does _nothing_ about
> the underlying fact that they're driver code plus other stuff, and as such
> provides no real advantage in terms of organization.
If you want to draw a line between net/ and drivers/net I propose
following idea:
net/ - everything that is about networking (or library for it) and
interacts only within the system (kernel<->user, or in-kernel)
drivers/net/ - everything that is a connecting point between the
system and external world - be it hardware, other VMs or hypervisor.
net/ would include wireless stack, all kinds of loopback devices,
tunnels (incl. vlan), bridging, bonding, tuntap, etc.
drivers/net/ would keep only what is hardware or external ABI dependent
Just my 2 cents (3 grosze ;-).
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-05-26 14:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 12:45 [RFC Patch] bonding: move to net/ directory Américo Wang
2011-05-23 15:13 ` Andy Gospodarek
2011-05-24 14:00 ` Américo Wang
2011-05-24 15:03 ` Andy Gospodarek
2011-05-25 12:32 ` Américo Wang
2011-05-25 15:01 ` Neil Horman
2011-05-26 9:11 ` Américo Wang
2011-05-26 13:38 ` Neil Horman
2011-05-24 16:33 ` Neil Horman
2011-05-25 12:43 ` Américo Wang
2011-05-25 15:20 ` Neil Horman
2011-05-26 9:32 ` Américo Wang
2011-05-26 13:50 ` Neil Horman
2011-05-26 14:25 ` Michał Mirosław [this message]
2011-06-06 16:34 ` Américo Wang
2011-06-06 16:50 ` Joe Perches
2011-06-06 17:04 ` Eric Dumazet
2011-06-06 17:20 ` Joe Perches
2011-06-06 17:31 ` Jeff Kirsher
2011-06-06 20:11 ` Ben Hutchings
2011-06-06 17:31 ` Jeff Kirsher
2011-06-18 2:48 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikrsr5sZ4aZ5aEmfBSvPE0mEL8g0g@mail.gmail.com \
--to=mirqus@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).