From: DMITRIY GRUZMAN <xmb836@motorola.com>
To: netdev@vger.kernel.org
Subject: usbnet: why is by default dev->rx_urb_size equal to dev->hard_mtu?
Date: Thu, 28 Apr 2011 18:00:12 -0500 [thread overview]
Message-ID: <BANLkTim-h9F93D7xk1sHuEzfrzbgMCgFgQ@mail.gmail.com> (raw)
Hello,
Currently, usbnet_probe() in drivers/net/usb/usbnet.c driver sets
dev->rx_urb_size equal to dev->hard_mtu unless the dev->rx_urb size is
previously set in the bind() call. I do not think that there is any
correlation between those values and I think that setting
dev->rx_urb_size to dev->maxpacket would be more appropriate.
Please provide your comments so I know if I should proceed with making
such a change.
Thanks,
Dmitriy Gruzman
reply other threads:[~2011-04-28 23:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim-h9F93D7xk1sHuEzfrzbgMCgFgQ@mail.gmail.com \
--to=xmb836@motorola.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).