From: "Michał Mirosław" <mirqus@gmail.com>
To: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch 1/9] [PATCH] qeth: convert to hw_features part 2
Date: Thu, 12 May 2011 10:12:51 +0200 [thread overview]
Message-ID: <BANLkTimAisv82ZbFb8D1AkL8vuK1V5zAXw@mail.gmail.com> (raw)
In-Reply-To: <20110512072132.GA31817@tuxmaker.boeblingen.de.ibm.com>
W dniu 12 maja 2011 09:21 użytkownik Frank Blaschka
<blaschka@linux.vnet.ibm.com> napisał:
> On Thu, May 12, 2011 at 07:59:45AM +0200, Michał Mirosław wrote:
>> 2011/5/12 <frank.blaschka@de.ibm.com>:
>> > Set rx csum default to hw checksumming again.
>> > Remove sysfs interface for rx csum (checksumming) and TSO (large_send).
>> > With the new hw_features it does not work to keep the old sysfs
>> > interface in parallel. Convert options.checksum_type to new hw_features.
>> [...]
>> > + /* hw may have changed during offline or recovery */
>> > + if (!qeth_is_supported(card, IPA_INBOUND_CHECKSUM)) {
>> [...]
>>
>> This check should go to ndo_fix_features callback. If it fails then
>> just return features &~NETIF_F_RXCSUM from there ...
>>
>> > +update_feature:
>> > + rtnl_lock();
>> > + card->dev->hw_features &= ~NETIF_F_RXCSUM;
>> > + card->dev->features &= ~NETIF_F_RXCSUM;
>> > + netdev_update_features(card->dev);
>> > + rtnl_unlock();
>>
>> ... and then this should be just:
>> rtnl_lock();
>> netdev_update_features(card->dev);
>> rtnl_unlock();
>>
> This code is part of the recovery, assuming the recovery detects the hw
> has lost it's rx csum capability I still don't understand how ndo_fix_features
> come into play?
ndo_fix_features is always called before ndo_set_features to alter
features that are to be enabled. So in this case, it should check if
checksumming is available and remove NETIF_F_RXCSUM from the set if it
isn't. The resulting set (after further cleanup by core code) is
passed to ndo_set_features if the features had changed. hw_features
only control what can be requested by user.
I assume that if the device can loose the checksumming capability
during runtime, it can also regain it. Above solution will
automatically reenable checksumming if its requested and the
capability comes back.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-05-12 8:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 5:43 [patch 0/9] [resend] s390: network feature patches for net-next frank.blaschka
2011-05-12 5:43 ` [patch 1/9] [PATCH] qeth: convert to hw_features part 2 frank.blaschka
2011-05-12 5:59 ` Michał Mirosław
2011-05-12 7:21 ` Frank Blaschka
2011-05-12 8:12 ` Michał Mirosław [this message]
2011-05-12 11:10 ` Frank Blaschka
2011-05-12 11:25 ` Michał Mirosław
2011-05-12 11:59 ` Frank Blaschka
2011-05-12 22:02 ` David Miller
2011-05-12 5:43 ` [patch 2/9] [PATCH] qeth: add OSA concurrent hardware trap frank.blaschka
2011-05-12 5:43 ` [patch 3/9] [PATCH] qeth: add owner to ccw driver frank.blaschka
2011-05-12 5:43 ` [patch 4/9] [PATCH] claw: remove unused return code handling frank.blaschka
2011-05-12 5:43 ` [patch 5/9] [PATCH] lcs: get rid of compile warning frank.blaschka
2011-05-12 5:43 ` [patch 6/9] [PATCH] ctcm: " frank.blaschka
2011-05-12 5:43 ` [patch 7/9] [PATCH] iucv: " frank.blaschka
2011-05-12 5:43 ` [patch 8/9] [PATCH] af_iucv: " frank.blaschka
2011-05-12 5:43 ` [patch 9/9] [PATCH] convert old cpumask API into new one frank.blaschka
-- strict thread matches above, loose matches on Subject: below --
2011-05-13 4:45 [patch 0/9] [resend v2] s390: network feature patches for net-next frank.blaschka
2011-05-13 4:45 ` [patch 1/9] [PATCH] qeth: convert to hw_features part 2 frank.blaschka
2011-05-13 7:38 ` Michał Mirosław
2011-05-13 7:57 ` Frank Blaschka
2011-05-13 8:07 ` Michał Mirosław
2011-05-10 11:50 [patch 0/9] s390: network feature patches for net-next frank.blaschka
2011-05-10 11:50 ` [patch 1/9] [PATCH] qeth: convert to hw_features part 2 frank.blaschka
2011-05-10 13:19 ` Michał Mirosław
2011-05-10 14:09 ` Frank Blaschka
2011-05-10 14:33 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimAisv82ZbFb8D1AkL8vuK1V5zAXw@mail.gmail.com \
--to=mirqus@gmail.com \
--cc=blaschka@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).