netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory
Date: Thu, 26 May 2011 17:11:35 +0800	[thread overview]
Message-ID: <BANLkTimEFg0Q=12z2_R4NNQ_VjRH=qhp2w@mail.gmail.com> (raw)
In-Reply-To: <20110525150144.GB11867@hmsreliant.think-freely.org>

On Wed, May 25, 2011 at 11:01 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
> While thats a fine rule to draw a distinction on, it also creates other
> organizational oddities.  By this reasoning, the loopback/tun-tap and xen
> netfront drivers should also be moved to /net.  While this might be an ok move
> to make, I think we can all agree, that while they don't touch specific
> hardware, they implement instances of the driver model, and as such are
> reasonably placed in /drivers.
>

Hmm, after reading Andy's comments again, I think his point is
probably bridge has STP management code which makes a difference
with bonding, but you know, we have 802.3ad in bonding too.

> This is really a false assertion.  Theres nothing more or less hard about
> finding bonding code in /drivers than there is in /net.  grep and find let you
> locate the code in either place equally well, and cscope really makes it all
> moot anyway.
>

Sometimes cscope sucks, especially when you meet function pointers
which are pretty common in net code. When I grep netpoll code, I have to
do `grep ndo_netpoll_setup -nr net/  drivers/net`, if bonding were in net/
`grep -nr net/` is enough. 'netdev_rx_handler_register' too.

  reply	other threads:[~2011-05-26  9:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 12:45 [RFC Patch] bonding: move to net/ directory Américo Wang
2011-05-23 15:13 ` Andy Gospodarek
2011-05-24 14:00   ` Américo Wang
2011-05-24 15:03     ` Andy Gospodarek
2011-05-25 12:32       ` Américo Wang
2011-05-25 15:01         ` Neil Horman
2011-05-26  9:11           ` Américo Wang [this message]
2011-05-26 13:38             ` Neil Horman
2011-05-24 16:33     ` Neil Horman
2011-05-25 12:43       ` Américo Wang
2011-05-25 15:20         ` Neil Horman
2011-05-26  9:32           ` Américo Wang
2011-05-26 13:50             ` Neil Horman
2011-05-26 14:25               ` Michał Mirosław
2011-06-06 16:34                 ` Américo Wang
2011-06-06 16:50                   ` Joe Perches
2011-06-06 17:04                     ` Eric Dumazet
2011-06-06 17:20                       ` Joe Perches
2011-06-06 17:31                         ` Jeff Kirsher
2011-06-06 20:11                         ` Ben Hutchings
2011-06-06 17:31                     ` Jeff Kirsher
2011-06-18  2:48                       ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTimEFg0Q=12z2_R4NNQ_VjRH=qhp2w@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).