From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: More prefetch fall-out
Date: Sun, 22 May 2011 11:38:44 -0700 [thread overview]
Message-ID: <BANLkTimQAhP17Hg6D84gtCO3nJ_SSsDAeg@mail.gmail.com> (raw)
In-Reply-To: <1306088626.12435.27.camel@edumazet-laptop>
On Sun, May 22, 2011 at 11:23 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> Taking a look at various skb_queue_walk* call sites, I think prefetches
> are not a clear win, I would just remove them all from skbuff.h
Hmm.
I did that, and it turns out that we also have:
- *lots* of network drivers that use "prefetch" (without including prefetch.h)
- net/netlabel/netlabel_addrlist.h doing the same.
and fixing that up is annoying "grunt work".
So for now, I think I'll just do the "add the <linux/prefetch.h> to
<linux/skbuff.h>" thing, and leave networking alone. That makes
everything compile ("allyesconfig") even with my "you *have* to
include <linux/prefetch.h>" test-patch.
Linus
next prev parent reply other threads:[~2011-05-22 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 17:49 More prefetch fall-out Linus Torvalds
2011-05-22 18:23 ` Eric Dumazet
2011-05-22 18:38 ` Linus Torvalds [this message]
2011-05-22 18:51 ` Eric Dumazet
2011-05-22 21:02 ` Paul Gortmaker
2011-05-23 0:39 ` David Miller
2011-05-22 22:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimQAhP17Hg6D84gtCO3nJ_SSsDAeg@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).