Re: [PATCH] net: Abstract features usage.

["Michał Mirosław" <mirqus@gmail.com>]

2011/5/24 Mahesh Bandewar <maheshb@google.com>:
> Define macros to set/clear/test bits for feature set usage. This will eliminate
> the direct use of these fields and enable future ease in managing these fields.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> ---
>  include/linux/netdev_features.h |  137 +++++++++++++++++++++++++++++++++++++++
>  include/linux/netdevice.h       |   35 ++---------
>  2 files changed, 142 insertions(+), 30 deletions(-)
>  create mode 100644 include/linux/netdev_features.h
>
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> new file mode 100644
> index 0000000..97bf8c4
> --- /dev/null
> +++ b/include/linux/netdev_features.h
> @@ -0,0 +1,137 @@
> +#ifndef        _NETDEV_FEATURES_H
> +#define        _NETDEV_FEATURES_H
> +
> +/* Forward declarations */
> +struct net_device;
> +
> +typedef        unsigned long *nd_feature_t;
> +
> +/* Net device feature bits; if you change something,
> + * also update netdev_features_strings[] in ethtool.c */
> +enum netdev_features {
> +       SG_BIT,                 /* Scatter/gather IO. */
[...]

Please split this change (introducing enum + converting NETIF_F_*
defines to use it). This part is a nice cleanup, but I think the
bitmap idea is still not worth the trouble until u64 runs out.

Best Regards,
Michał Mirosław