netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matvejchikov Ilya <matvejchikov@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH] NET: slip, fix ldisc->open retval
Date: Fri, 6 May 2011 20:23:09 +0400	[thread overview]
Message-ID: <BANLkTinWqaoMNHbOb5PbZzewQafWhBfY4Q@mail.gmail.com> (raw)

TTY layer expects 0 if the ldisc->open operation succeeded.

Signed-off-by : Matvejchikov Ilya <matvejchikov@gmail.com>
---
 drivers/net/slip.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/slip.c b/drivers/net/slip.c
index 86cbb9e..8ec1a9a 100644
--- a/drivers/net/slip.c
+++ b/drivers/net/slip.c
@@ -853,7 +853,9 @@ static int slip_open(struct tty_struct *tty)
 	/* Done.  We have linked the TTY line to a channel. */
 	rtnl_unlock();
 	tty->receive_room = 65536;	/* We don't flow control */
-	return sl->dev->base_addr;
+
+	/* TTY layer expects 0 on success */
+	return 0;

 err_free_bufs:
 	sl_free_bufs(sl);
-- 
1.7.5.1

             reply	other threads:[~2011-05-06 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 16:23 Matvejchikov Ilya [this message]
2011-05-08 17:37 ` [PATCH] NET: slip, fix ldisc->open retval Oliver Hartkopp
2011-05-08 18:25   ` Alan Cox
2011-05-09 18:53 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinWqaoMNHbOb5PbZzewQafWhBfY4Q@mail.gmail.com \
    --to=matvejchikov@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).