From: Ming Lei <tom.leiming@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usbnet: runtime pm: fix out of memory
Date: Wed, 4 May 2011 14:59:41 +0800 [thread overview]
Message-ID: <BANLkTinZK_qjO7u+ckG_83_paVyMeyrgPw@mail.gmail.com> (raw)
In-Reply-To: <201105030953.44131.oneukum@suse.de>
Hi,
2011/5/3 Oliver Neukum <oneukum@suse.de>:
> Do the devices in question use cdc_ether?
No, the device is smsc95xx, which is compound device and is
integrated into pandaboard.
> The problem I see with this patch is that cdc_ether uses .reset_resume = usbnet_resume
> Therefore the device will not have been reset from the viewpoint of the device, yet
> the device may be open, so the bug would strike again.
>
> It seems to me that this patch is not wrong as such, but incomplete.
Since it is not cdc device, so the patch should be complete, the idea behind
the patch is reasonable: only start to schedule urb for data packets after the
interface is opened.
Even from the comment below in usbnet_open, it is a generic fix for
this kind of issue, we should always put the device into a 'known safe" state
before starting communication.
int usbnet_open (struct net_device *net)
......
// put into "known safe" state
......
thanks,
--
Ming Lei
next prev parent reply other threads:[~2011-05-04 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 8:37 [PATCH] usbnet: runtime pm: fix out of memory tom.leiming-Re5JQEeQqe8AvxtiuMwx3w
2011-05-02 22:52 ` David Miller
[not found] ` <20110502.155214.179953741.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-05-03 7:53 ` Oliver Neukum
2011-05-04 6:59 ` Ming Lei [this message]
[not found] ` <BANLkTinZK_qjO7u+ckG_83_paVyMeyrgPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-04 7:26 ` Oliver Neukum
[not found] ` <201105040926.12355.oneukum-l3A5Bk7waGM@public.gmane.org>
2011-05-05 17:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinZK_qjO7u+ckG_83_paVyMeyrgPw@mail.gmail.com \
--to=tom.leiming@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).