netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org, martin.wilck@ts.fujitsu.com,
	john.r.fastabend@intel.com
Subject: Re: [PATCH net-2.6] ixgbe: only enable WoL for magic packet by default
Date: Fri, 8 Apr 2011 11:13:07 -0700	[thread overview]
Message-ID: <BANLkTiner9iMOF8Y333OxBPhySSu9AwG+g@mail.gmail.com> (raw)
In-Reply-To: <1302187315-16487-1-git-send-email-andy@greyhouse.net>

On Thu, Apr 7, 2011 at 07:41, Andy Gospodarek <andy@greyhouse.net> wrote:
> Martin Wilck <martin.wilck@ts.fujitsu.com> reported that systems using
> the ixgbe-driver that were capable of WoL were rebooting almost as soon
> as they were shut down.  This is because the default WoL settings
> enabled magic packet, broadcast, unicast, and multicast.
>
> Other Intel devices seem to use the stored eeprom value for initial WoL
> capabilities.  The 82578DM (e1000e) and 82576 (igb) the devices I looked
> at had only the magic packet enabled in the eeprom, so that seems
> appropriate on ixgbe-based devices as well.  I set the WoL options on my
> 82578DM to be the same default as the ixgbe devices (umbg) and saw the
> same as Martin -- almost as soon as my box shutdown, it booted again.
>
> This patch changes the default to only be the magic packet.  This is the
> same as the default for most Intel and non-Intel hardware currently
> upstream.
>
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> CC: Martin Wilck <martin.wilck@ts.fujitsu.com>
>

Thanks Andy! I have added the patch to my queue.

-- 
Cheers,
Jeff

      reply	other threads:[~2011-04-08 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07 14:41 [PATCH net-2.6] ixgbe: only enable WoL for magic packet by default Andy Gospodarek
2011-04-08 18:13 ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTiner9iMOF8Y333OxBPhySSu9AwG+g@mail.gmail.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=andy@greyhouse.net \
    --cc=john.r.fastabend@intel.com \
    --cc=martin.wilck@ts.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).