From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [RFC Patch] bonding: move to net/ directory
Date: Wed, 25 May 2011 20:43:21 +0800 [thread overview]
Message-ID: <BANLkTinoRXmEAp0mbZdxSmMbntsE-QeRsQ@mail.gmail.com> (raw)
In-Reply-To: <20110524163323.GB28521@hmsreliant.think-freely.org>
On Wed, May 25, 2011 at 12:33 AM, Neil Horman <nhorman@tuxdriver.com> wrote:
> This all sounds like change for the sake of change to me. I don't see any
> compelling argument for moving bonding (or bridging or vlans, etc) around at
> all. All of these software drivers have feet in multple subsystems, but that
> just means that theres not going to be a compelling argument to move them any
> place, at least not without an immediate subsequent argument that it really
> belonged back where it was. Unless you can show a solid benefit to moving the
> code, I don't see why any reorganization is needed.
Well, as a people who worked on bonding code, I have no problem to know
bonding code is under drivers/net/, but for people who don't know this, probably
net/ is the first place they want to search.
The other similar thing is that pktgen is in net/core/ while netconsole is in
drivers/net/, which seems a little strange too.
vlan vs macvlan is the third example.
In short, there are three callers of netdev_rx_handler_register(), macvlan,
bonding and bridge, only bridge code stays in net/ directory.
next prev parent reply other threads:[~2011-05-25 12:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 12:45 [RFC Patch] bonding: move to net/ directory Américo Wang
2011-05-23 15:13 ` Andy Gospodarek
2011-05-24 14:00 ` Américo Wang
2011-05-24 15:03 ` Andy Gospodarek
2011-05-25 12:32 ` Américo Wang
2011-05-25 15:01 ` Neil Horman
2011-05-26 9:11 ` Américo Wang
2011-05-26 13:38 ` Neil Horman
2011-05-24 16:33 ` Neil Horman
2011-05-25 12:43 ` Américo Wang [this message]
2011-05-25 15:20 ` Neil Horman
2011-05-26 9:32 ` Américo Wang
2011-05-26 13:50 ` Neil Horman
2011-05-26 14:25 ` Michał Mirosław
2011-06-06 16:34 ` Américo Wang
2011-06-06 16:50 ` Joe Perches
2011-06-06 17:04 ` Eric Dumazet
2011-06-06 17:20 ` Joe Perches
2011-06-06 17:31 ` Jeff Kirsher
2011-06-06 20:11 ` Ben Hutchings
2011-06-06 17:31 ` Jeff Kirsher
2011-06-18 2:48 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinoRXmEAp0mbZdxSmMbntsE-QeRsQ@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).