From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Sebastian.Poehn@belden.com
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ixgbe: RX ntuple feature must check num_rx_queues
Date: Tue, 10 May 2011 11:52:02 -0700 [thread overview]
Message-ID: <BANLkTinq4u321Cf=JtkKOW=6WMP=y78+SQ@mail.gmail.com> (raw)
In-Reply-To: <OFA595D9DB.234DFCEB-ON8525788C.004ED485-8525788C.004ED485@BeldenCDT.com>
On Tue, May 10, 2011 at 07:21, <Sebastian.Poehn@belden.com> wrote:
> The driver must check how much RX queues there are, not TX queues.
>
> --- ixgbe_ethtool.c.orig 2011-05-10 16:18:00.313745560 +0200
> +++ ixgbe_ethtool.c 2011-05-10 16:18:23.285747635 +0200
> @@ -2349,9 +2349,9 @@ static int ixgbe_set_rx_ntuple(struct ne
>
> /*
> * Don't allow programming if the action is a queue greater than
> - * the number of online Tx queues.
> + * the number of online Rx queues.
> */
> - if ((fs->action >= adapter->num_tx_queues) ||
> + if ((fs->action >= adapter->num_rx_queues) ||
> (fs->action < ETHTOOL_RXNTUPLE_ACTION_DROP))
> return -EINVAL;
>
> Signed-off-by: Sebastian Poehn <sebastian.poehn@belden.com>
Thanks Sebastian, I have added the patch to my queue of patches.
--
Cheers,
Jeff
prev parent reply other threads:[~2011-05-10 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 14:21 [PATCH] ixgbe: RX ntuple feature must check num_rx_queues Sebastian.Poehn
2011-05-10 18:52 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTinq4u321Cf=JtkKOW=6WMP=y78+SQ@mail.gmail.com' \
--to=jeffrey.t.kirsher@intel.com \
--cc=Sebastian.Poehn@belden.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).