netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Hardin <chardin@2wire.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET
Date: Wed, 17 Oct 2007 14:36:10 -0700	[thread overview]
Message-ID: <C33BCE5A.25D04%chardin@2wire.com> (raw)

Kernel needs to respond to an SADB_GET with the same message type to conform
to the RFC 2367 Section 3.1.5

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 7969f8a..fb4fee1 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -1552,7 +1552,7 @@ static int pfkey_get(struct sock *sk, struct sk_buff
*skb,
 
        out_hdr = (struct sadb_msg *) out_skb->data;
        out_hdr->sadb_msg_version = hdr->sadb_msg_version;
-       out_hdr->sadb_msg_type = SADB_DUMP;
+       out_hdr->sadb_msg_type = SADB_GET;
        out_hdr->sadb_msg_satype = pfkey_proto2satype(proto);
        out_hdr->sadb_msg_errno = 0;
        out_hdr->sadb_msg_reserved = 0;


             reply	other threads:[~2007-10-17 21:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17 21:36 Charles Hardin [this message]
2007-10-18  2:29 ` [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C33BCE5A.25D04%chardin@2wire.com \
    --to=chardin@2wire.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).