netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET
@ 2007-10-17 21:36 Charles Hardin
  2007-10-18  2:29 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Charles Hardin @ 2007-10-17 21:36 UTC (permalink / raw)
  To: netdev, linux-kernel

Kernel needs to respond to an SADB_GET with the same message type to conform
to the RFC 2367 Section 3.1.5

diff --git a/net/key/af_key.c b/net/key/af_key.c
index 7969f8a..fb4fee1 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -1552,7 +1552,7 @@ static int pfkey_get(struct sock *sk, struct sk_buff
*skb,
 
        out_hdr = (struct sadb_msg *) out_skb->data;
        out_hdr->sadb_msg_version = hdr->sadb_msg_version;
-       out_hdr->sadb_msg_type = SADB_DUMP;
+       out_hdr->sadb_msg_type = SADB_GET;
        out_hdr->sadb_msg_satype = pfkey_proto2satype(proto);
        out_hdr->sadb_msg_errno = 0;
        out_hdr->sadb_msg_reserved = 0;


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET
  2007-10-17 21:36 [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET Charles Hardin
@ 2007-10-18  2:29 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-18  2:29 UTC (permalink / raw)
  To: chardin; +Cc: netdev, linux-kernel

From: Charles Hardin <chardin@2wire.com>
Date: Wed, 17 Oct 2007 14:36:10 -0700

> Kernel needs to respond to an SADB_GET with the same message type to conform
> to the RFC 2367 Section 3.1.5

I can't apply this:

1) We need you to provide an appropriate Signed-off-by: line
   in the changelog of your patch.

2) Your email client corrupted the patch, changing tabs into spaces,
   and adding newline breaks to long lines.

Please resubmit with these two errors corrected, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-18  2:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-17 21:36 [PATCH] pfkey: sending an SADB_GET responds with an SADB_GET Charles Hardin
2007-10-18  2:29 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).