From: Scott Feldman <scofeldm@cisco.com>
To: Stephen Hemminger <shemminger@vyatta.com>,
David Miller <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [RFC] net: change bridge/macvlan hook to be be generic
Date: Tue, 04 May 2010 17:58:56 -0700 [thread overview]
Message-ID: <C80610E0.2E2EC%scofeldm@cisco.com> (raw)
In-Reply-To: <20100504153758.0ed3a87d@nehalam>
On 5/4/10 3:37 PM, "Stephen Hemminger" <shemminger@vyatta.com> wrote:
> The existing macvlan and bridge have special hooks in the packet input
> path. This patch changes it to a generic hook chain, like the packet type
> processing. I have been wanting to look into flow based switching, etc...
Can this be further simplified by saying that a netdev can only be hooked by
one mux (macvlan, bridge, etc) at any given time, so there is never more
than one element in the hook chain. If so, then we just need a single hook,
not a chain.
It seems odd to me that a dev would have both macvlan_port != NULL and
br_port != NULL. Can dev be in a macvlan and a bridge at the same time?
-scott
next prev parent reply other threads:[~2010-05-05 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 22:37 [RFC] net: change bridge/macvlan hook to be be generic Stephen Hemminger
2010-05-05 0:58 ` Scott Feldman [this message]
2010-05-10 15:58 ` Patrick McHardy
2010-05-10 17:14 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C80610E0.2E2EC%scofeldm@cisco.com \
--to=scofeldm@cisco.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).