From: roprabhu <roprabhu@cisco.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: <netdev@vger.kernel.org>, <chrisw@redhat.com>,
<scofeldm@cisco.com>, <arnd@arndb.de>
Subject: Re: [PATCH] iproute2: add VF_PORT support
Date: Tue, 09 Nov 2010 15:30:29 -0800 [thread overview]
Message-ID: <C8FF1995.188E2%roprabhu@cisco.com> (raw)
In-Reply-To: <20101109142219.0166576a@nehalam>
On 11/9/10 2:22 PM, "Stephen Hemminger" <shemminger@vyatta.com> wrote:
> On Tue, 09 Nov 2010 14:20:11 -0800
> Roopa Prabhu <roprabhu@cisco.com> wrote:
>
>> response == PORT_VDP_RESPONSE_SUCCESS ?
>> + "SUCCESS" :
>> + response == PORT_VDP_RESPONSE_INVALID_FORMAT ?
>> + "INVALID FORMAT" :
>> + response == PORT_VDP_RESPONSE_INSUFFICIENT_RESOURCES ?
>> + "INSUFFICIENT RESOURCES" :
>> + response == PORT_VDP_RESPONSE_UNUSED_VTID ?
>> + "UNUSED VTID" :
>> + response == PORT_VDP_RESPONSE_VTID_VIOLATION ?
>> + "VTID VIOLATION" :
>> + response == PORT_VDP_RESPONSE_VTID_VERSION_VIOALTION ?
>> + "VTID VERSION VIOLATION" :
>> + response == PORT_VDP_RESPONSE_OUT_OF_SYNC ?
>> + "OUT-OF-SYNC" :
>> + response == PORT_PROFILE_RESPONSE_SUCCESS ?
>> + "SUCCESS" :
>> + response == PORT_PROFILE_RESPONSE_INPROGRESS ?
>> + "IN-PROGRESS" :
>> + response == PORT_PROFILE_RESPONSE_INVALID ?
>> + "INVALID" :
>> + response == PORT_PROFILE_RESPONSE_BADSTATE ?
>> + "BAD STATE" :
>> + response == PORT_PROFILE_RESPONSE_INSUFFICIENT_RESOURCES ?
>> + "INSUFFICIENT RESOURCES" :
>> + response == PORT_PROFILE_RESPONSE_ERROR ?
>> + "ERROR" :
>> + "UNKNOWN RESPONSE");
>
> That's an ugly way to do this.
> Make it a real function nor array.
Ok sounds good. Will re-spin. Thanks.
next prev parent reply other threads:[~2010-11-09 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 22:20 [PATCH] iproute2: add VF_PORT support Roopa Prabhu
2010-11-09 22:22 ` Stephen Hemminger
2010-11-09 23:30 ` roprabhu [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-10 0:47 Roopa Prabhu
2010-10-21 12:41 Roopa Prabhu
2010-06-01 18:40 Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8FF1995.188E2%roprabhu@cisco.com \
--to=roprabhu@cisco.com \
--cc=arnd@arndb.de \
--cc=chrisw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).