From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Yakovlev Subject: Re: [PATCH 1/5] drivers/net/wireless/ipw2x00/ipw2100.c: introduce missing initialization Date: Sun, 19 Aug 2012 14:07:46 +0400 Message-ID: References: <1345325159-7365-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "John W. Linville" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julia Lawall Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 19 August 2012 13:49, Julia Lawall wrote: > From: Julia Lawall > > The result of one call to a function is tested, and then at the second call > to the same function, the previous result, and not the current result, is > tested again. > > Also changed &bssid to bssid, at the suggestion of Stanislav Yakovlev. > > The semantic match that finds the first problem is as follows: > > (http://coccinelle.lip6.fr/) > > // > @@ > expression ret; > identifier f; > statement S1,S2; > @@ > > *ret = f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 > ... when any > *f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 > // > > Signed-off-by: Julia Lawall > > --- > v2: changed &bssid to bssid > Thank you, Julia. Stanislav. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html