From: Stanislav Yakovlev <stas.yakovlev@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: linville@tuxdriver.com, yongjun_wei@trendmicro.com.cn,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipw2200: use is_zero_ether_addr() and is_broadcast_ether_addr()
Date: Fri, 24 Aug 2012 01:13:07 +0400 [thread overview]
Message-ID: <CA++WF2Nv_qb_jAnxhiR+WMjD4nwa3hAwMOSNqNtxc1LDX9ouXQ@mail.gmail.com> (raw)
In-Reply-To: <CAPgLHd_K=bbQ=zpKY8kW3HCGeuE3GwCCQOAg+gJoFdCv9SnVrg@mail.gmail.com>
Hi,
On 23 August 2012 10:54, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using is_zero_ether_addr() and is_broadcast_ether_addr() instead of
> directly use memcmp() to determine if the ethernet address is all zeros.
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/net/wireless/ipw2x00/ipw2200.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
Looks fine, thanks.
Stanislav.
prev parent reply other threads:[~2012-08-23 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 6:54 [PATCH] ipw2200: use is_zero_ether_addr() and is_broadcast_ether_addr() Wei Yongjun
2012-08-23 21:13 ` Stanislav Yakovlev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA++WF2Nv_qb_jAnxhiR+WMjD4nwa3hAwMOSNqNtxc1LDX9ouXQ@mail.gmail.com \
--to=stas.yakovlev@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).