Re: [PATCH net-next v2] Configure bridge FDB ageing time using netlink.

[Siva Mannem <siva.mannem.lnx@gmail.com>]

On Mon, Mar 16, 2015 at 7:43 AM, David Miller <davem@davemloft.net> wrote:
> From: Siva Mannem <siva.mannem.lnx@gmail.com>
> Date: Sat, 14 Mar 2015 07:10:29 +0530
>
>> This patch allows user to configure bridge's FDB ageing using
>> netlink(for ex, iproute2). Allowed range is 10 seconds to 1000000 seconds
>> as per ieee8021QBridgeFdbAgingTime.
>>
>> Signed-off-by: Siva Mannem <siva.mannem.lnx@gmail.com>
>
> The behavior of br_changelink() leaves a lot to be desired, and this
> change is making it worse.
>
> The range of the netlink attributes, the only thing that can cause
> an error, should be validated for all attributes _first_.
>
> Because right now you can have several values change state,
> then the last one has a range error, and an error is returned
> without rolling back the state.
>
> This is terrible.
>
> When this happens the user has not reliable way to figure out
> that some of the state changes it requested happened, and
> exactly which ones those were.
>
> If an error is thrown we _MUST_ not make any state changes to
> the bridge whatsoever.

Agree. Will work on it. Can it be a follow-on patch?

-- 
Regards,
Siva Mannem.