From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AFFC48BD3 for ; Wed, 26 Jun 2019 15:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF962085A for ; Wed, 26 Jun 2019 15:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaGM59eH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728110AbfFZPgk (ORCPT ); Wed, 26 Jun 2019 11:36:40 -0400 Received: from mail-yw1-f65.google.com ([209.85.161.65]:35072 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727873AbfFZPgi (ORCPT ); Wed, 26 Jun 2019 11:36:38 -0400 Received: by mail-yw1-f65.google.com with SMTP id k128so1397740ywf.2 for ; Wed, 26 Jun 2019 08:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nB2SlIBqZ7G1UjtTzO1Yn/x7hThan4DYNNuCoZrdMGc=; b=IaGM59eH59k6bwEWOreYpMBhZBij5GVXZtYQfz4HtOADv00s2mss3VXMaVkNWAAQ/t mn4vrvrpfDjxewcC1tonypR2ZNcCM7OtveCyjNOR/atT0DkA+vBURZgZU2g+bNlPoDNa sxoI2/1ubQZY8ziyyTwMYejLpSOGvhu4Kw3MFZglfssraqux6YMQHkfj+Bst58dvBNZA u/ztiL+y7xAYFT19tVcwp7GT6Psdjo1IqgvZdlDFrxhnt27DkVeE72d3xc1NI6T9dxyG MpOshn4sTw1PZ82LnEBFhYnK375ukdOVgidZpEOssL7/CQ4C3jEm5yMHtu2sKR3MDUj2 9JVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nB2SlIBqZ7G1UjtTzO1Yn/x7hThan4DYNNuCoZrdMGc=; b=LC7Fz2HCOMn4bA546nZVyzWO9waBugKRK77GlCoEDrwjt6hDt0fJuj4gZt1+jrcRHd yBdYpD++9xxYIwnlM/EKcnmv72PfwWGuCGa0GAzBqXCuOCq/a4SZpdZWljr+hYQKv0Te LCRDCMGyMHZo9UWD1ZhaxAeHeeHai+lrkIFPL6QVSNLI9+XONqc8F8KZpWPcbgTh3rRV rqM7yFqhv+qVesey28//LGLEIeyxMelrh41HpqdjgAGdbj1eLSpA0ByGd28yc494u+1h sTiC2PVYVKmFA5D6JppnINDsz2drnsB2qbGXnNzph2QZuWxOLBAM+lbSc0fcJvoTSRZe k0Uw== X-Gm-Message-State: APjAAAVgIAGRektLHbF3iGUIdTNLfB3pnWkrKoRNQPzLgyJ1/OTAe49T 01OYVdYmdp68fGB6zD31l+2It/d3 X-Google-Smtp-Source: APXvYqwb/GM31RlVsoX57M2XcitbnBIDsaYRDBLzYiDJkK1viz+5nTVu7SbVHOMS8ECASOcyD7vJzw== X-Received: by 2002:a81:ee05:: with SMTP id l5mr3302178ywm.245.1561563396689; Wed, 26 Jun 2019 08:36:36 -0700 (PDT) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id i84sm1381937ywi.0.2019.06.26.08.36.35 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 26 Jun 2019 08:36:35 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id w9so1565591ybe.9 for ; Wed, 26 Jun 2019 08:36:35 -0700 (PDT) X-Received: by 2002:a25:908b:: with SMTP id t11mr3363414ybl.473.1561563395120; Wed, 26 Jun 2019 08:36:35 -0700 (PDT) MIME-Version: 1.0 References: <20190617074858.32467-1-bpoirier@suse.com> <20190617074858.32467-5-bpoirier@suse.com> <20190626113959.GC27420@f1> In-Reply-To: <20190626113959.GC27420@f1> From: Willem de Bruijn Date: Wed, 26 Jun 2019 11:35:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [EXT] [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size To: Benjamin Poirier Cc: Manish Chopra , GR-Linux-NIC-Dev , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jun 26, 2019 at 7:40 AM Benjamin Poirier wrote: > > On 2019/06/26 09:36, Manish Chopra wrote: > > > -----Original Message----- > > > From: Benjamin Poirier > > > Sent: Monday, June 17, 2019 1:19 PM > > > To: Manish Chopra ; GR-Linux-NIC-Dev > > NIC-Dev@marvell.com>; netdev@vger.kernel.org > > > Subject: [EXT] [PATCH net-next 05/16] qlge: Remove rx_ring.sbq_buf_size > > > > > > External Email > > > > > > ---------------------------------------------------------------------- > > > Tx rings have sbq_buf_size = 0 but there's no case where the code actually > > > tests on that value. We can remove sbq_buf_size and use a constant instead. > > > > > > > Seems relevant to RX ring, not the TX ring ? > > qlge uses "struct rx_ring" for rx and for tx completion rings. > > The driver's author is probably laughing now at the success of his plan > to confuse those who would follow in his footsteps. :-) Reviewed-by: Willem de Bruijn