From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Vishal Kulkarni <vishal@chelsio.com>,
"David S . Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] cxgb4: sched: Use refcount_t for refcount
Date: Fri, 2 Aug 2019 09:39:51 -0400 [thread overview]
Message-ID: <CA+FuTSc8WBx2PCUhn-sLtYHQR-OROXm2pUN9SDj7P-Bd8432UQ@mail.gmail.com> (raw)
In-Reply-To: <20190802083541.12602-1-hslester96@gmail.com>
On Fri, Aug 2, 2019 at 4:36 AM Chuhong Yuan <hslester96@gmail.com> wrote:
>
> refcount_t is better for reference counters since its
> implementation can prevent overflows.
> So convert atomic_t ref counters to refcount_t.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Convert refcount from 0-base to 1-base.
This changes the initial value from 0 to 1, but does not change the
release condition. So this introduces an accounting bug?
next prev parent reply other threads:[~2019-08-02 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 8:35 [PATCH v2 1/2] cxgb4: sched: Use refcount_t for refcount Chuhong Yuan
2019-08-02 13:39 ` Willem de Bruijn [this message]
2019-08-02 14:27 ` Chuhong Yuan
2019-08-02 14:52 ` Willem de Bruijn
2019-08-02 15:10 ` Chuhong Yuan
2019-08-02 15:14 ` Willem de Bruijn
-- strict thread matches above, loose matches on Subject: below --
2019-08-02 8:41 Chuhong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSc8WBx2PCUhn-sLtYHQR-OROXm2pUN9SDj7P-Bd8432UQ@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).