From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xie He <xie.he.0141@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices
Date: Fri, 30 Oct 2020 12:29:26 -0400 [thread overview]
Message-ID: <CA+FuTSczR03KGNdksH2KyAyzoR9jc6avWNrD+UWyc7sXd44J4w@mail.gmail.com> (raw)
In-Reply-To: <20201030022839.438135-5-xie.he.0141@gmail.com>
On Thu, Oct 29, 2020 at 10:33 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> When an skb is received on a normal (non-Ethernet-emulating) PVC device,
> call skb_reset_mac_header before we pass it to upper layers.
>
> This is because normal PVC devices don't have header_ops, so any header we
> have would not be visible to upper layer code when sending, so the header
> shouldn't be visible to upper layer code when receiving, either.
>
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Cc: Krzysztof Halasa <khc@pm.waw.pl>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Should this go to net if a bugfix though?
next prev parent reply other threads:[~2020-10-30 16:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:28 [PATCH net-next v4 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype Xie He
2020-10-30 2:28 ` [PATCH net-next v4 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames Xie He
2020-10-30 16:34 ` Willem de Bruijn
2020-10-30 20:01 ` Xie He
2020-10-30 21:11 ` Willem de Bruijn
2020-10-30 21:27 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner Xie He
2020-10-30 2:28 ` [PATCH net-next v4 3/5] net: hdlc_fr: Improve the initial checks when we receive an skb Xie He
2020-10-30 16:30 ` Willem de Bruijn
2020-10-30 19:21 ` Xie He
2020-10-30 21:20 ` Willem de Bruijn
2020-10-30 21:36 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices Xie He
2020-10-30 16:29 ` Willem de Bruijn [this message]
2020-10-30 20:08 ` Xie He
2020-10-30 21:28 ` Willem de Bruijn
2020-10-30 21:49 ` Xie He
2020-10-30 22:22 ` Willem de Bruijn
2020-10-30 22:52 ` Xie He
2020-10-30 2:28 ` [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype Xie He
2020-10-30 16:32 ` Willem de Bruijn
2020-10-30 19:29 ` Xie He
2020-10-30 21:25 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSczR03KGNdksH2KyAyzoR9jc6avWNrD+UWyc7sXd44J4w@mail.gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).