From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Alexander Lobakin <alobakin@pm.me>
Subject: Re: [PATCH net-next 1/8] udp: fixup csum for GSO receive slow path
Date: Tue, 23 Mar 2021 21:49:10 -0400 [thread overview]
Message-ID: <CA+FuTSdV=vRGtNcmtdtnEVKLCSca4HyftNEntTGXAPQRFccuMA@mail.gmail.com> (raw)
In-Reply-To: <CA+FuTSd6fOaj6bJssyXeyL-LWvSEdSH+QchHUG8Ga-=EQ634Lg@mail.gmail.com>
> > > > @@ -2168,6 +2168,7 @@ static int udp_queue_rcv_one_skb(struct sock *sk, struct sk_buff *skb)
> > > > static int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
> > > > {
> > > > struct sk_buff *next, *segs;
> > > > + int csum_level;
> > > > int ret;
> > > >
> > > > if (likely(!udp_unexpected_gso(sk, skb)))
> > > > @@ -2175,9 +2176,18 @@ static int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
> > > >
> > > > BUILD_BUG_ON(sizeof(struct udp_skb_cb) > SKB_GSO_CB_OFFSET);
> > > > __skb_push(skb, -skb_mac_offset(skb));
> > > > + csum_level = !!(skb_shinfo(skb)->gso_type &
> > > > + (SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP_TUNNEL_CSUM));
> > > > segs = udp_rcv_segment(sk, skb, true);
> > > > skb_list_walk_safe(segs, skb, next) {
> > > > __skb_pull(skb, skb_transport_offset(skb));
> > > > +
> > > > + /* UDP GSO packets looped back after adding UDP encap land here with CHECKSUM none,
> > > > + * instead of adding another check in the tunnel fastpath, we can force valid
> > > > + * csums here (packets are locally generated).
> > > > + * Additionally fixup the UDP CB
> > > > + */
Btw, instead of this comment plus a comment in the ipv6 code that
points back to this ipv4 comment, I would move the explanation to
the udp_post_segment_fix_csum function itself.
next prev parent reply other threads:[~2021-03-24 1:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 17:01 [PATCH net-next 0/8] udp: GRO L4 improvements Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 1/8] udp: fixup csum for GSO receive slow path Paolo Abeni
2021-03-22 13:18 ` Willem de Bruijn
2021-03-22 16:34 ` Paolo Abeni
2021-03-24 1:45 ` Willem de Bruijn
2021-03-24 1:49 ` Willem de Bruijn [this message]
2021-03-24 14:37 ` Paolo Abeni
2021-03-24 22:36 ` Willem de Bruijn
2021-03-25 10:56 ` Paolo Abeni
2021-03-25 13:53 ` Willem de Bruijn
2021-03-25 16:47 ` Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 2/8] udp: skip fwd/list GRO for tunnel packets Paolo Abeni
2021-03-22 13:24 ` Willem de Bruijn
2021-03-22 16:41 ` Paolo Abeni
2021-03-24 1:54 ` Willem de Bruijn
2021-03-24 14:50 ` ! Paolo Abeni
2021-03-24 22:45 ` ! Willem de Bruijn
2021-03-21 17:01 ` [PATCH net-next 3/8] udp: properly complete L4 GRO over UDP tunnel packet Paolo Abeni
2021-03-22 13:30 ` Willem de Bruijn
2021-03-22 16:59 ` Paolo Abeni
2021-03-24 2:13 ` Willem de Bruijn
2021-03-21 17:01 ` [PATCH net-next 4/8] udp: never accept GSO_FRAGLIST packets Paolo Abeni
2021-03-22 13:42 ` Willem de Bruijn
2021-03-22 17:09 ` Paolo Abeni
2021-03-24 2:21 ` Willem de Bruijn
2021-03-24 18:59 ` Paolo Abeni
2021-03-24 22:12 ` Willem de Bruijn
2021-03-25 11:50 ` Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 5/8] vxlan: allow L4 GRO passthrou Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 6/8] geneve: allow UDP " Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 7/8] bareudp: " Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 8/8] selftests: net: add UDP GRO forwarding self-tests Paolo Abeni
2021-03-22 13:44 ` Willem de Bruijn
2021-03-22 17:18 ` Paolo Abeni
2021-03-23 17:12 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSdV=vRGtNcmtdtnEVKLCSca4HyftNEntTGXAPQRFccuMA@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=alobakin@pm.me \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).