From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D91CC433E0 for ; Thu, 4 Feb 2021 13:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E840564EE2 for ; Thu, 4 Feb 2021 13:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236266AbhBDNVd (ORCPT ); Thu, 4 Feb 2021 08:21:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235940AbhBDNVb (ORCPT ); Thu, 4 Feb 2021 08:21:31 -0500 Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F32C061573 for ; Thu, 4 Feb 2021 05:20:50 -0800 (PST) Received: by mail-vs1-xe2c.google.com with SMTP id x201so1747682vsc.0 for ; Thu, 04 Feb 2021 05:20:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/hiAWODlHRq/hh7f1ucWvSrSst2f1xH5hskFyLCl0MA=; b=OXWFlO8TE+q6/CZZOysJVRBo1HsI+hN+CM5jRCjYoMo2pA8lt+Ik2W8pLNt2pEnDRd 7W3qOEI7wT/H/qNF/WT2iQtVnDCFzEUQX0ms/eOHuJv0ghI0uY9DUgl7GCJz+e8dVCIt ysjZIzoqkZV2xBuetFpcQnWVP2CStP5FruRSW9z7X9+ah4WiDOocZBXksFnqidRQPrlH KmTwVf/ta+iymt06PrhgRGnVsFDDU7N3CJRkPb7etrrpY17kFZqhU+no99kWz+espLMj ZkyUsKqkLAe3Q8a+jgPrgIwEFl9jKMDHA6fWIWwp/F5tVe89aOXoAsOOdNGTuUyDE/77 Na6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/hiAWODlHRq/hh7f1ucWvSrSst2f1xH5hskFyLCl0MA=; b=EmftcrDpvYPmFScc6VD3BRoHdiC7EZqc2dx4BBsAloTy3wFl9cB9RJ3ql+a4G1TUiy q5IHPgZQDiNclFNnDLv0nhTN1jlfeJk/Fhr/ar+QrhvwqpnYpnXjyJluWg3MpyS3LQ/m 1LqlEmFqX9SAs/5ABQdSV7I9li1r0hTRo+xccUK2hJztsjLkSkLco/gNvx1fmGuIGMx8 9j354JfEZWQ3Pff3jezz+yj7iqhAD84Saoayst59uH9Ttk+KW4CsGre5DKeefTMdLIYG SRo/jo1NnCEwY8FqW9LwKVzIUa3RD8mOwtnvOW9vZhNDCzxCcn9FWj9lpsc1dgTzOjnt uKbw== X-Gm-Message-State: AOAM5323wbxYzAOtamvAFCvDx0wytQkrTl5ObhCiRI3GvkmiSOPyqdZ+ XAylFazSH52Kg213Qp9hEHDokIiV1So= X-Google-Smtp-Source: ABdhPJzlBIIEXJPCk+ki2rYnug1PyON7r1W3PZve1vvS0HIfzGKtwm6QYio65+c2rn8hlWnhNNufuQ== X-Received: by 2002:a67:fad5:: with SMTP id g21mr5234796vsq.29.1612444849736; Thu, 04 Feb 2021 05:20:49 -0800 (PST) Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com. [209.85.221.170]) by smtp.gmail.com with ESMTPSA id y189sm670778vky.21.2021.02.04.05.20.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Feb 2021 05:20:48 -0800 (PST) Received: by mail-vk1-f170.google.com with SMTP id e10so669258vkm.2 for ; Thu, 04 Feb 2021 05:20:47 -0800 (PST) X-Received: by 2002:a1f:2c4c:: with SMTP id s73mr5166808vks.3.1612444846575; Thu, 04 Feb 2021 05:20:46 -0800 (PST) MIME-Version: 1.0 References: <20210204101550.21595-1-qiangqing.zhang@nxp.com> <20210204101550.21595-3-qiangqing.zhang@nxp.com> In-Reply-To: <20210204101550.21595-3-qiangqing.zhang@nxp.com> From: Willem de Bruijn Date: Thu, 4 Feb 2021 08:20:09 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac_resume() To: Joakim Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , David Miller , Jakub Kicinski , Network Development , Andrew Lunn , Florian Fainelli , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 4, 2021 at 5:18 AM Joakim Zhang wrote: > > Slightly adjust the order of the codes in stmmac_resume(), remove the > check "if (!device_may_wakeup(priv->device) || !priv->plat->pmt)". > > Signed-off-by: Joakim Zhang This commit message says what the code does, but not why or why it's correct.