From: Willem de Bruijn <willemb@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping
Date: Wed, 6 Aug 2014 10:23:25 -0400 [thread overview]
Message-ID: <CA+FuTSf96KH=JkO4Va4pfbvYHngHjxtTc33ipbif_xC9kdgaLQ@mail.gmail.com> (raw)
In-Reply-To: <1407308749.14097.13.camel@edumazet-glaptop2.roam.corp.google.com>
> I believe you missed fact that a GSO packet can be split into 2 or many
> skbs, when tcp_write_xmit() has to send a lower amount.
>
> This is done in tso_fragment()
Thanks, I missed that case. I'll look into it.
> Also, I am a bit worried about retransmits ?
For the same reason, i.e., possibly calling tcp_fragment?
next prev parent reply other threads:[~2014-08-06 14:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 2:11 [PATCH net-next v4 0/6] net-timestamp: new tx tstamps and tcp Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 1/6] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 2/6] net-timestamp: move timestamp flags out of sk_flags Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 3/6] net-timestamp: add key to disambiguate concurrent datagrams Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 4/6] net-timestamp: SCHED timestamp on entering packet scheduler Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 5/6] net-timestamp: TCP timestamping Willem de Bruijn
2014-08-06 6:25 ` Eric Dumazet
2014-08-06 6:55 ` Eric Dumazet
2014-08-06 13:08 ` Willem de Bruijn
2014-08-06 14:36 ` Eric Dumazet
2014-08-06 7:05 ` Eric Dumazet
2014-08-06 9:49 ` [PATCH net-next] net-timestamp: sock_tx_timestamp() fix Eric Dumazet
2014-08-06 12:52 ` Willem de Bruijn
2014-08-06 19:38 ` David Miller
2014-08-06 14:23 ` Willem de Bruijn [this message]
2014-08-06 14:37 ` [PATCH net-next v4 5/6] net-timestamp: TCP timestamping Eric Dumazet
2014-08-06 19:20 ` Willem de Bruijn
2014-08-06 21:32 ` David Miller
2014-08-07 0:59 ` Willem de Bruijn
2014-08-07 2:03 ` David Miller
2014-08-07 3:43 ` Willem de Bruijn
2014-08-07 3:50 ` David Miller
2014-08-05 2:11 ` [PATCH net-next v4 6/6] net-timestamp: ACK timestamp for bytestreams Willem de Bruijn
2014-08-05 2:16 ` [PATCH net-next v4 0/6] net-timestamp: new tx tstamps and tcp Willem de Bruijn
2014-08-05 23:36 ` David Miller
2014-08-07 23:09 ` Andi Kleen
2014-08-07 23:39 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSf96KH=JkO4Va4pfbvYHngHjxtTc33ipbif_xC9kdgaLQ@mail.gmail.com' \
--to=willemb@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).