From: Willem de Bruijn <willemb@google.com>
To: David Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next v4] rps: selective flow shedding during softnet overflow
Date: Tue, 23 Apr 2013 20:00:45 -0400 [thread overview]
Message-ID: <CA+FuTSfKoVDQ2FqS_h-X6pkjmJuegXMZ2p9tvmoXNDFQ-0dLNA@mail.gmail.com> (raw)
In-Reply-To: <20130423.184140.2020239496583590253.davem@davemloft.net>
On Tue, Apr 23, 2013 at 6:41 PM, David Miller <davem@davemloft.net> wrote:
> From: Willem de Bruijn <willemb@google.com>
> Date: Tue, 23 Apr 2013 16:31:34 -0400
>
>> - disable the kconfig option by default, as it is workload specific.
>
> If this logic only kicks in during overload, I see no reason why we
> shouldn't have this protection enabled unconditionally, all the time.
>
> Does it hurt performance under normal workloads?
>
> If the new logic is controlled by overload thresholds then it should
> have no impact whatsoever in non-overload scenerios.
It only adds one branch in that case. I was (probably too) conservative.
Do you want me to resubmit the entire patch with the Kconfig
dependency on RPS that Eric proposed?
next prev parent reply other threads:[~2013-04-24 0:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:46 [PATCH] rps: selective flow shedding during softnet overflow Willem de Bruijn
2013-04-19 17:58 ` Eric Dumazet
2013-04-22 20:40 ` Willem de Bruijn
2013-04-22 20:46 ` [PATCH net-next v2] " Willem de Bruijn
2013-04-22 22:30 ` Eric Dumazet
2013-04-23 18:45 ` Willem de Bruijn
2013-04-23 18:46 ` [PATCH net-next v3] " Willem de Bruijn
2013-04-23 19:18 ` Eric Dumazet
2013-04-23 20:30 ` Willem de Bruijn
2013-04-23 20:31 ` [PATCH net-next v4] " Willem de Bruijn
2013-04-23 21:23 ` Stephen Hemminger
2013-04-23 21:37 ` Willem de Bruijn
2013-04-23 21:37 ` Eric Dumazet
2013-04-23 21:52 ` Stephen Hemminger
2013-04-23 22:34 ` David Miller
2013-04-24 0:09 ` Eric Dumazet
2013-04-24 0:37 ` [PATCH net-next v5] " Willem de Bruijn
2013-04-24 1:07 ` Eric Dumazet
2013-04-25 8:20 ` David Miller
2013-05-20 14:02 ` [PATCH net-next v6] " Willem de Bruijn
2013-05-20 16:00 ` Eric Dumazet
2013-05-20 16:08 ` Willem de Bruijn
2013-05-20 20:48 ` David Miller
2013-04-24 1:25 ` [PATCH net-next v4] " Jamal Hadi Salim
2013-04-24 1:32 ` Eric Dumazet
2013-04-24 1:44 ` Jamal Hadi Salim
2013-04-24 2:11 ` Eric Dumazet
2013-04-24 13:00 ` Jamal Hadi Salim
2013-04-24 14:41 ` Eric Dumazet
2013-04-23 22:33 ` David Miller
2013-04-23 21:34 ` Eric Dumazet
2013-04-23 22:41 ` David Miller
2013-04-23 23:11 ` Eric Dumazet
2013-04-23 23:15 ` David Miller
2013-04-23 23:26 ` Eric Dumazet
2013-04-24 0:03 ` Stephen Hemminger
2013-04-24 0:00 ` Willem de Bruijn [this message]
2013-04-23 20:46 ` [PATCH net-next v3] " Eric Dumazet
2013-04-19 19:03 ` [PATCH] " Stephen Hemminger
2013-04-19 19:21 ` Eric Dumazet
2013-04-19 20:11 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+FuTSfKoVDQ2FqS_h-X6pkjmJuegXMZ2p9tvmoXNDFQ-0dLNA@mail.gmail.com \
--to=willemb@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).