From: Francesco Ruggeri <fruggeri@arista.com>
To: Francesco Ruggeri <fruggeri@arista.com>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 1/1] net-next: do not store needed_headroom in ip_tunnel_xmit
Date: Sat, 20 Feb 2016 06:55:09 -0800 [thread overview]
Message-ID: <CA+HUmGiV3ziOafun_4-wGovB8k5pmefLGbcUHnpvrFMpLStrFA@mail.gmail.com> (raw)
In-Reply-To: <1455942374-17650-1-git-send-email-fruggeri@arista.com>
On Fri, Feb 19, 2016 at 8:26 PM, Francesco Ruggeri <fruggeri@arista.com> wrote:
> Misconfigurations can result in local tunnel loops being created.
> __dev_queue_xmit catches packets caught in a loop and drops them,
> but the affected tunnels' needed_headroom can be corrupted in the
> process as it is recursively updated.
The problem with the patch is that it might force a pskb_expand_head
in the most common cases.
On the other hand if a loop is created then it may not be enough to
undo the configuration and the tunnel device itself should be
reinitialized.
Anybody have a better suggestion?
Thanks,
Francesco
prev parent reply other threads:[~2016-02-20 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 4:26 [PATCH 1/1] net-next: do not store needed_headroom in ip_tunnel_xmit Francesco Ruggeri
2016-02-20 14:55 ` Francesco Ruggeri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+HUmGiV3ziOafun_4-wGovB8k5pmefLGbcUHnpvrFMpLStrFA@mail.gmail.com \
--to=fruggeri@arista.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).